Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min amount for rate limit #222

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Add min amount for rate limit #222

merged 2 commits into from
Aug 21, 2023

Conversation

GNaD13
Copy link
Contributor

@GNaD13 GNaD13 commented Aug 15, 2023

Close #221

originalChainBBalance = gotBalance
// add rate limit 5%
chainBRateLimitKeeper := suite.chainB.RateLimit()
msgAddRateLimit := ratelimittypes.MsgAddRateLimit{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we express the min amount here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the testing. I showed it, so that anyone can easily understand.

@GNaD13 GNaD13 requested a review from blasrodri August 16, 2023 13:00
Copy link
Contributor

@vuong177 vuong177 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vuong177 vuong177 merged commit d52fcc9 into main Aug 21, 2023
11 of 14 checks passed
tungleanh0902 pushed a commit to notional-labs/composable-cosmos that referenced this pull request Mar 7, 2024
@hoank101 hoank101 deleted the dang/update-rate-limit branch April 8, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add min amount for rate limit
3 participants