Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic on use of nil authKeeper/accountKeeper #527

Closed
wants to merge 1 commit into from
Closed

Fix panic on use of nil authKeeper/accountKeeper #527

wants to merge 1 commit into from

Conversation

joe-bowman
Copy link
Collaborator

fixes #526

  • rename authKeeper to accountKeeper (because, it's an accountKeeper ;) )
  • use types.AccountKeeper over minttypes.AccountKeeper (it's the same, just cleaner to use own types)
  • ensure accountKeeper is set on NewKeeper instantiation to avoid panic

@joe-bowman joe-bowman requested a review from hoank101 May 30, 2024 18:54
@kkast kkast deleted the branch ComposableFi:hoa/add-test May 30, 2024 19:02
@kkast kkast closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkast kkast kkast approved these changes

@hoank101 hoank101 Awaiting requested review from hoank101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joe-bowman @kkast