fix: reconcile session status with live PR state#95
Open
AgentWrapper wants to merge 2 commits intomainfrom
Open
fix: reconcile session status with live PR state#95AgentWrapper wants to merge 2 commits intomainfrom
AgentWrapper wants to merge 2 commits intomainfrom
Conversation
When a PR is merged on GitHub, the session metadata file still shows the old status (e.g. "pr_open"). The dashboard fetches live PR state from GitHub API (correctly showing "merged") but never updates the session status, causing contradictory displays: "PR Open" in the session header while "Merged" appears in the PR details card. Add reconcileSessionStatus() that updates session.status based on live pr.state after SCM enrichment. Called in all 3 data paths: SSR page, API list endpoint, and API detail endpoint. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
The test "returns done when PR is merged even if session status is stale (pr_open)" was using status: "merged" instead of status: "pr_open", making it a duplicate of the existing test. Fixed to use the stale status and removed the redundant second test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session.statuscomes from stale metadata (pr_open) whilepr.stateis fetched live from GitHub API (merged) — nothing reconciled themreconcileSessionStatus()that updatessession.statusbased on livepr.stateafter SCM enrichment, called in all 3 data paths (SSR page, API list, API detail)Test plan
serialize.test.tscovering all reconciliation scenarios (merged, closed, stale statuses, terminal statuses, no PR, full pipeline)get-attention-level.test.tsverifying attention level is "done" when PR is merged regardless of stale session status🤖 Generated with Claude Code