fix: Triggers parity #1003
fix: Triggers parity #1003
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 867f5b6 in 1 minute and 34 seconds
More details
- Looked at
107lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. js/src/cli/triggers.ts:273
- Draft comment:
ThegetOpenAPIClient()function is called but its return value is not used. This is likely a mistake. Consider using the returned client or removing the call if it's unnecessary. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_8m6YkGmkJVRPceTZ
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
js/src/cli/triggers.ts
Outdated
| } | ||
|
|
||
| async handleSetAction(callbackURL: string): Promise<void> { | ||
| getOpenAPIClient() |
There was a problem hiding this comment.
The getOpenAPIClient() function is called but its return value is not used. This is likely a mistake. Consider using the returned client or removing the call if it's unnecessary.
|
This comment was generated by github-actions[bot]! JS SDK Coverage Report📊 Coverage report for JS SDK can be found at the following URL: 📁 Test report folder can be found at the following URL: |
…osio into fix-cli-parity-4
Important
Add CLI support for enabling triggers and managing callback URLs with new
TriggerEnableandTriggerCallbackclasses.TriggerEnableclass to enable existing triggers via CLI.TriggerCallbackclass to manage callback URLs for triggers, withsetandgetcommands.ConnectionsCommandto includeTriggerEnableandTriggerCallbackcommands.This description was created by
for 867f5b6. It will automatically update as commits are pushed.