fix: bring eslint + TS issues to zero

.github/workflows/lint_js.yml

@@ -34,7 +34,7 @@ jobs:
       run: pnpm install --frozen-lockfile
 
     - name: Run ESLint
-      run: pnpm run eslint
+      run: pnpm run lint
       continue-on-error: false
 
     - name: Run Prettier

js/.prettierrc

@@ -20,5 +20,6 @@
     "useTabs": false,
     "embeddedLanguageFormatting": "auto",
     "vueIndentScriptAndStyle": false,
-    "experimentalTernaries": false
-  }
+    "experimentalTernaries": false,
+    "plugins": ["prettier-plugin-organize-imports"]
+}

js/eslint.config.mjs

@@ -26,7 +26,7 @@ export default [
       "no-var": "warn",
       "prefer-const": "warn",
       "no-console": "warn",
-      "@typescript-eslint/no-explicit-any": "warn",
+      "@typescript-eslint/no-explicit-any": "error",
       "@typescript-eslint/no-unused-vars": [
         "warn",
         {

js/package.json

@@ -11,11 +11,10 @@
     "openapispec:generate": "npx @hey-api/openapi-ts",
     "run:cli": "ts-node src/cli/index.ts",
     "run:sample": "ts-node sample.ts",
-    "eslint": "eslint 'src/**/*.{ts,js}' --max-warnings=261",
     "prettier": "prettier --write 'src/**/*.{ts,js,cjs}'",
     "prettier:check": "prettier --check 'src/**/*.{ts,js,mjs,cjs}'",
     "build": "rollup -c rollup.config.mjs && ./setup_cli.sh",
-    "lint": "eslint 'src/**/*.ts'",
+    "lint": "eslint 'src/**/*.{ts,js}' --ignore-pattern 'src/sdk/client/**'",
     "format": "pnpm lint && pnpm prettier"
   },
   "bin": {
@@ -75,6 +74,7 @@
     "open": "^8.4.0",
     "openai": "^4.50.0",
     "prettier": "^3.4.2",
+    "prettier-plugin-organize-imports": "^4.1.0",
     "pusher-js": "8.4.0-rc2",
     "regenerator-runtime": "^0.14.1",
     "resolve-package-path": "^4.0.3",

js/prettier.config.mjs

@@ -1,5 +1,5 @@
 const config = {
-    plugins: [],
+    plugins: ['prettier-plugin-organize-imports'],
     semi: true,
     printWidth: 140,
     tabWidth: 4,

js/src/cli/actions.ts

@@ -1,8 +1,9 @@
+/* eslint-disable no-console */
 import chalk from "chalk";
 import { Command } from "commander";
+import { ListActionsV2Data } from "../sdk/client";
 import client from "../sdk/client/client";
 import { getOpenAPIClient } from "../sdk/utils/config";
-import { ListActionsV2Data } from "../sdk/client";
 
 export default class ActionCommand {
   private program: Command;

js/src/cli/add.ts

@@ -1,10 +1,36 @@
+/* eslint-disable no-console */
 import chalk from "chalk";
 import { Command } from "commander";
-import { Composio } from "../sdk";
 import inquirer from "inquirer";
 import open from "open";
+import { Composio } from "../sdk";
 import { GetConnectorInfoResDTO, GetConnectorListResDTO } from "../sdk/client";
 
+type TInputField = {
+  name: string;
+  displayName?: string;
+  display_name?: string;
+  expected_from_customer?: boolean;
+  required?: boolean;
+  message_name?: string;
+  type?: string;
+};
+
+type THandleActionOptions = {
+  force?: boolean;
+  skipDefaultConnector?: boolean;
+  noBrowser?: boolean;
+  integrationId?: string;
+  authMode?: string;
+  scope?: string[];
+  label?: string[];
+};
+
+type TAuthScheme = {
+  auth_mode: string;
+  fields: TInputField[];
+};
+
 export default class AddCommand {
   private program: Command;
 
@@ -42,15 +68,7 @@ export default class AddCommand {
 
   private async handleAction(
     appName: string,
-    options: {
-      force?: boolean;
-      skipDefaultConnector?: boolean;
-      noBrowser?: boolean;
-      integrationId?: string;
-      authMode?: string;
-      scope?: string[];
-      label?: string[];
-    }
+    options: THandleActionOptions
   ): Promise<void> {
     const composioClient = new Composio({});
     let integration:
@@ -158,25 +176,25 @@ export default class AddCommand {
 
   private async setupConnections(
     integrationId: string,
-    options: any
+    options: Record<string, unknown>
   ): Promise<void> {
     const composioClient = new Composio({});
     const data = await composioClient.integrations.get({ integrationId });
     const { expectedInputFields } = data!;
 
     const config = await this.collectInputFields(
-      expectedInputFields as any,
+      expectedInputFields as unknown as TInputField[],
       true
     );
 
     if (options.scope) {
-      config.scopes = options.scope.join(",");
+      config.scopes = (options.scope as string[]).join(",");
     }
 
     const connectionData = await composioClient.connectedAccounts.create({
       integrationId,
       data: config,
-      labels: options.label,
+      labels: options.label as string[],
     });
 
     if (connectionData.connectionStatus === "ACTIVE") {
@@ -216,7 +234,7 @@ export default class AddCommand {
     appName: string,
     skipDefaultConnectorAuth: boolean = false,
     userAuthMode?: string,
-    options?: any
+    options?: THandleActionOptions
   ) {
     const composioClient = new Composio({});
     const app = await composioClient.apps.get({
@@ -234,7 +252,7 @@ export default class AddCommand {
 
     const testConnectors = app.testConnectors || [];
 
-    const config: Record<string, any> = {};
+    const config: Record<string, unknown> = {};
     let useComposioAuth = true;
     const authSchemeExpectOauth = ["bearer_token", "api_key", "basic"];
     if (
@@ -273,8 +291,8 @@ export default class AddCommand {
         (app.auth_schemes[0]?.auth_mode as string | undefined));
 
     const authModes = (app.auth_schemes || []).reduce(
-      (acc: Record<string, any>, scheme: any) => {
-        acc[scheme.auth_mode] = scheme;
+      (acc, scheme: Record<string, unknown>) => {
+        acc[scheme.auth_mode as string] = scheme;
         return acc;
       },
       {}
@@ -300,7 +318,7 @@ export default class AddCommand {
       return this.handleBasicAuth(
         app,
         selectedAuthMode,
-        selectedAuthScheme,
+        selectedAuthScheme as TAuthScheme,
         config,
         integrationName
       );
@@ -309,27 +327,27 @@ export default class AddCommand {
     return this.handleOAuth(
       app,
       selectedAuthMode,
-      selectedAuthScheme,
+      selectedAuthScheme as TAuthScheme,
       config,
       integrationName,
-      options.noBrowser,
-      options.scope,
+      options?.noBrowser ?? false,
+      options?.scope ?? [],
       useComposioAuth
     );
   }
 
   private async handleBasicAuth(
-    app: any,
+    app: Record<string, unknown>,
     authMode: string,
-    authScheme: any,
-    config: Record<string, any>,
+    authScheme: TAuthScheme,
+    config: Record<string, unknown>,
     integrationName: string
   ) {
     const composioClient = new Composio({});
     const authConfig = await this.collectInputFields(authScheme.fields);
 
     const integration = await composioClient.integrations.create({
-      appId: app.appId,
+      appId: app.appId as string,
       authScheme: authMode,
       useComposioAuth: false,
       name: integrationName,
@@ -340,33 +358,39 @@ export default class AddCommand {
   }
 
   private async handleOAuth(
-    app: any,
+    app: Record<string, unknown>,
     authMode: string,
-    authScheme: any,
-    config: Record<string, any>,
+    authScheme: TAuthScheme,
+    config: Record<string, unknown>,
     integrationName: string,
     noBrowser: boolean,
     scopes: string[],
     useComposioAuth: boolean
   ) {
     if (useComposioAuth) {
       return this.setupIntegration(
-        app,
+        app as {
+          appId: string;
+        },
         authMode,
         useComposioAuth,
         {},
         integrationName
       );
     }
 
-    const authConfig = await this.collectInputFields(authScheme.fields);
+    const authConfig = await this.collectInputFields(
+      authScheme.fields as TInputField[]
+    );
 
     if (scopes) {
       authConfig.scopes = scopes.join(",");
     }
 
     return this.setupIntegration(
-      app,
+      app as {
+        appId: string;
+      },
       authMode,
       useComposioAuth,
       authConfig,
@@ -375,17 +399,10 @@ export default class AddCommand {
   }
 
   async collectInputFields(
-    fields: {
-      name: string;
-      displayName: string;
-      display_name: string;
-      expected_from_customer: boolean;
-      required: boolean;
-      type: string;
-    }[],
+    fields: TInputField[],
     isConnection = false
-  ): Promise<Record<string, any>> {
-    const config: Record<string, any> = {};
+  ): Promise<Record<string, unknown>> {
+    const config: Record<string, unknown> = {};
 
     for (const field of fields) {
       if (field.expected_from_customer && !isConnection) {
@@ -395,7 +412,7 @@ export default class AddCommand {
       const { [field.name]: value } = await inquirer.prompt({
         type: "input",
         name: field.name,
-        message: field.displayName || field.display_name,
+        message: (field.displayName || field.display_name) as string,
       });
 
       if (value) {
@@ -407,10 +424,12 @@ export default class AddCommand {
   }
 
   async setupIntegration(
-    app: any,
-    authMode: any,
+    app: {
+      appId: string;
+    },
+    authMode: string,
     useComposioAuth: boolean,
-    config: Record<string, any>,
+    config: Record<string, unknown>,
     name: string
   ) {
     const composioClient = new Composio({});

js/src/cli/apps.ts

@@ -2,12 +2,12 @@
 import chalk from "chalk";
 import { Command } from "commander";
 
-import { getOpenAPIClient } from "../sdk/utils/config";
 import client from "../sdk/client/client";
+import { getOpenAPIClient } from "../sdk/utils/config";
 
-import resolvePackagePath from "resolve-package-path";
 import fs from "fs";
 import path from "path";
+import resolvePackagePath from "resolve-package-path";
 
 type ErrorWithMessage = {
   message: string;

js/src/cli/connections.ts

@@ -29,7 +29,7 @@ export default class ConnectionsCommand {
     });
 
     if (error) {
-      console.log(chalk.red((error as any).message));
+      console.log(chalk.red((error as Error).message));
       return;
     }
 
@@ -66,11 +66,13 @@ export class ConnectionsGetCommand {
     });
 
     if (error) {
-      console.log(chalk.red((error as any).message));
+      console.log(chalk.red((error as Error).message));
       return;
     }
 
-    for (const [key, value] of Object.entries(data as Record<string, any>)) {
+    for (const [key, value] of Object.entries(
+      data as Record<string, unknown>
+    )) {
       console.log(
         `- ${chalk.cyan.bold(key)}: ${JSON.stringify(value, null, 2)}`
       );