-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add plugin tests #1096
feat: add plugin tests #1096
Changes from all commits
cf4548c
e3d862b
b5f9e3f
b3d0029
ba782b7
e199c21
e93a7f6
7425b2f
a81c3eb
04992b2
89fcb4b
6e74212
9e55b6b
05944dd
67ce449
78fc5b1
62e767b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -102,6 +102,10 @@ jobs: | |||||||||||||||||
export E2B_API_KEY=${{ secrets.E2B_API_KEY_STAGING }} | ||||||||||||||||||
|
||||||||||||||||||
tox -e test -- -m 'not e2e and not swe' | ||||||||||||||||||
- name: Plugin tests | ||||||||||||||||||
if: matrix.python-version == '3.10' | ||||||||||||||||||
run: | | ||||||||||||||||||
tox -e plugins | ||||||||||||||||||
Comment on lines
+105
to
+108
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Conditional for plugin tests is incorrect. It should execute when matrix.python-version == '3.9'. 📝 Committable Code Suggestion
Suggested change
|
||||||||||||||||||
- if: matrix.python-version == '3.10' | ||||||||||||||||||
name: Upload test results to Codecov | ||||||||||||||||||
uses: codecov/test-results-action@v1 | ||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary conditional for uploading test results. It should always upload regardless of the python version.
📝 Committable Code Suggestion