Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: js release yml, reduce batch size, change telemetry payload #975

Merged
merged 11 commits into from
Dec 11, 2024
Merged

fix: js release yml, reduce batch size, change telemetry payload #975

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ee72090
feat: ignore commit step
himanshu-dixit Dec 10, 2024
b98a4f1
feat: version change
himanshu-dixit Dec 10, 2024
eb56f62
feat: version change
himanshu-dixit Dec 10, 2024
6ca47e3
feat: write
himanshu-dixit Dec 10, 2024
0f84c29
fix: contenxt issues
himanshu-dixit Dec 11, 2024
75f1f43
feat: prettier
himanshu-dixit Dec 11, 2024
cd8ba76
feat: error message
himanshu-dixit Dec 11, 2024
f9512c2
feat: error
himanshu-dixit Dec 11, 2024
ff5ae3b
feat: request id in client side
himanshu-dixit Dec 11, 2024
063b382
feat: bump version
himanshu-dixit Dec 11, 2024
4cdbf89
feat: update account
himanshu-dixit Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions .github/workflows/release_js_sdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ on:

jobs:
run-js-tests:
permissions:
contents: write
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a comment explaining why write permissions are needed here. This helps future maintainers understand the security implications and requirements.

timeout-minutes: 60
runs-on: ubuntu-latest

Expand All @@ -38,21 +40,6 @@ jobs:
env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}

- name: Update version
run: |
git config --global user.email "tech@composio.dev"
git config --global user.name "Composio"
npm version ${{ github.event.inputs.version }} --no-git-tag-version


- name: Commit and push
run: |
if git diff --quiet; then
echo "No changes to commit"
else
git commit -am "Release ${{ github.event.inputs.version }}" && git push
fi

- name: pnpm build
run: pnpm build

Expand Down
2 changes: 1 addition & 1 deletion js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "composio-core",
"version": "0.3.2",
"version": "0.4.0-beta",
"description": "",
"main": "dist/index.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion js/src/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const ACTIONS = {
// actions list end here
};

const COMPOSIO_VERSION = `0.3.0`;
const COMPOSIO_VERSION = `0.4.0-beta`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see version alignment between package.json and constants.js. Consider implementing a single source of truth for version numbers to prevent future mismatches. This could be done through a version management script or using package.json as the primary source.


module.exports = {
APPS,
Expand Down
Loading