Maintainability upgrades and fixes #399
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxmeinhold
reviewed
Sep 22, 2025
Collaborator
mxmeinhold
left a comment
mxmeinhold
left a comment
There was a problem hiding this comment.
took a look through, though I found it hard to read through all the formatting. Glancing through commits, seemed like there wasn't much in code changes, more in deps and CI?
Have a couple comments
120 line length Single quotes
pikachu0542
reviewed
Nov 4, 2025
Member
pikachu0542
left a comment
pikachu0542
left a comment
There was a problem hiding this comment.
Code looks good, need to run it locally to test
pikachu0542
reviewed
Nov 8, 2025
Member
pikachu0542
left a comment
pikachu0542
left a comment
There was a problem hiding this comment.
I was able to get it running locally, and it works. However, I cant seem to figure out how to test the mock user functionality, and with no open packets, I cant verify that the main functionality still works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone will need to double check this LOL