Maintainability upgrades and fixes #399
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxmeinhold
reviewed
Sep 22, 2025
.github/workflows/python-app.yml
Outdated
| - name: Lint with ruff | ||
| run: | | ||
| pylint packet/routes packet | ||
| ruff check packet |
There was a problem hiding this comment.
Looking at the ruff FAQ, seems like they're more confident in how well it can replace pylint than a few years ago, but it also discuss that they can be complimentary. Would it make sense to use ruff locally for anyone using it for commit hooks, and pylint in CI for completeness
There was a problem hiding this comment.
It wouldn't hurt, I just wanted to avoid any complications 2 linting systems could possibly bring.
There was a problem hiding this comment.
I think they can be tuned to work pretty well together, the pylint project uses both
120 line length Single quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone will need to double check this LOL