chore(pumpkin-core): Use clippy to detect disallowed types

.githooks/pre-commit

@@ -3,7 +3,6 @@
 set -eux
 
 ./scripts/fmt.sh --pre-commit
-./scripts/hash.sh --pre-commit
 ./scripts/clippy.sh --pre-commit
 ./scripts/documentation.sh --pre-commit
 ./scripts/deny.sh --pre-commit

pumpkin-crates/core/clippy.toml

@@ -0,0 +1,7 @@
+disallowed-types = [
+    { path = "std::collections::HashSet", reason = "use pumpkin_solver::containers::HashSet" },
+    { path = "std::collections::HashMap", reason = "use pumpkin_solver::containers::HashMap" },
+    { path = "rand::RngCore", reason = "use pumpkin_solver::basic_types::Random" },
+    { path = "rand::Rng", reason = "use pumpkin_solver::basic_types::Random" },
+    { path = "rand::SeedableRng", reason = "use pumpkin_solver::basic_types::Random" },
+]

pumpkin-crates/core/src/basic_types/random.rs

@@ -1,7 +1,15 @@
 use std::fmt::Debug;
 use std::ops::Range;
 
+#[allow(
+    clippy::disallowed_types,
+    reason = "we implement our random generator using rand"
+)]
 use rand::Rng;
+#[allow(
+    clippy::disallowed_types,
+    reason = "we implement our random generator using rand"
+)]
 use rand::SeedableRng;
 
 use crate::pumpkin_assert_moderate;
@@ -74,6 +82,10 @@ pub trait Random: Debug {
 // We provide a blanket implementation of the trait for any type which implements `SeedableRng`,
 // `Rng` and `Debug` to ensure that we can use any "regular" random generator where we expect an
 // implementation of Random.
+#[allow(
+    clippy::disallowed_types,
+    reason = "we implement our random generator using rand"
+)]
 impl<T> Random for T
 where
     T: SeedableRng + Rng + Debug,

pumpkin-crates/core/src/containers/mod.rs

@@ -11,6 +11,8 @@ pub use keyed_vec::*;
 pub(crate) use sparse_set::*;
 
 /// [`std::collections::HashMap`] that defaults to a deterministic hasher.
+#[allow(clippy::disallowed_types, reason = "this is how we define our HashMap")]
 pub type HashMap<K, V, Hasher = FnvBuildHasher> = std::collections::HashMap<K, V, Hasher>;
 /// [`std::collections::HashSet`] that defaults to a deterministic hasher.
+#[allow(clippy::disallowed_types, reason = "this is how we define our HashSet")]
 pub type HashSet<K, Hasher = FnvBuildHasher> = std::collections::HashSet<K, Hasher>;

pumpkin-crates/core/src/engine/constraint_satisfaction_solver.rs

@@ -5,6 +5,10 @@ use std::collections::VecDeque;
 use std::fmt::Debug;
 use std::time::Instant;
 
+#[allow(
+    clippy::disallowed_types,
+    reason = "any rand generator is a valid implementation of Random"
+)]
 use rand::SeedableRng;
 use rand::rngs::SmallRng;