Skip to content

feat(pumpkin-core): If the check-propagations flag is enabled, the state will run inference checkers on all propagations immediately #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
maartenflippo wants to merge 47 commits into
base: main
Choose a base branch
from
Open

feat(pumpkin-core): If the check-propagations flag is enabled, the state will run inference checkers on all propagations immediately #340

maartenflippo wants to merge 47 commits into from

Conversation

@maartenflippo
Copy link
Contributor

@maartenflippo maartenflippo commented Jan 11, 2026 •
edited
Loading

Effectively, it is the first step to implementing a streaming checker that runs alongside the solver. The standalone checker utilizes the inference checkers defined alongside the propagators, rather than having a duplicate implementation.

TODO

  • Migrate the inference checkers that are now still in the standalone checker.
  • Run the inference checker after a new constraint is learned
  • Probably clarify documentation once @ImkoMarijnissen has gone through the PR.

ImkoMarijnissen
ImkoMarijnissen previously requested changes Jan 12, 2026
View reviewed changes
@maartenflippo maartenflippo force-pushed the feat/integrated-checkers branch from 5aaa4be to 81d20e0 Compare January 16, 2026 11:53
@maartenflippo maartenflippo marked this pull request as ready for review January 16, 2026 16:22
@github-actions github-actions bot dismissed ImkoMarijnissen’s stale review January 16, 2026 16:23

Review re-requested

maartenflippo and others added 23 commits January 19, 2026 15:26
@maartenflippo
Only add inference checkers when checking propagations
075f754
@maartenflippo
Clarify docs
da533d7
@maartenflippo
Accept when any checker accepts
7d34487
@ImkoMarijnissen
fix: post checkers for other constructors as well
9495262
@maartenflippo
Fix time table checker profile calculation
0ff8048
@maartenflippo
Merge branch 'feat/integrated-checkers' of github.com:ConSol-Lab/Pump…
ef52729 
…kin into feat/integrated-checkers
@maartenflippo
Complete implementation of TestAtomic
f327564
@maartenflippo
Enable inference checkers in CI
3ee7f80
@maartenflippo
Implement absolute value checker
fe63bae
@maartenflippo
Supply the inference being checked to the checkers
4f4838a
@maartenflippo
Also supply fact in state checker
6f85273
@maartenflippo
Enable testing whether an atomic constrains a specific variable
79acb0d
@maartenflippo
Implement inference checker for maximum
2708656
@maartenflippo
Move binary equals checker to propagators crate
456ba66
@maartenflippo
Implement binary not equals checker
94ff8bc
@ImkoMarijnissen
feat: adding checker for disjunctive edge finding
daacfbc
@maartenflippo
Implement checker for integer multiplication
34153f8
@maartenflippo
Merge branch 'feat/integrated-checkers' of github.com:ConSol-Lab/Pump…
49fc810 
…kin into feat/integrated-checkers
@maartenflippo
Rename I32Ext to IntExt
6732010 
In preparation of making it generic over the integer type
@maartenflippo
Rename IntExt::I32 to IntExt::Int
761be59
@maartenflippo
Extend IntExt to work with i64
2537d73
@maartenflippo
Implement linear not equal checker
61cd43b
@ImkoMarijnissen
fix: adding checker for cumulative time tabling
d479d58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ImkoMarijnissen ImkoMarijnissen Awaiting requested review from ImkoMarijnissen

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maartenflippo @ImkoMarijnissen