-
Notifications
You must be signed in to change notification settings - Fork 1
Version 1.2.0: Sponge Gourd #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
f8f8d34 to
0031d01
Compare
lchladek
requested changes
Sep 24, 2024
Contributor
lchladek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good code, a few questions and some pre-flight reminders
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
This comment was marked as outdated.
This comment was marked as outdated.
lchladek
approved these changes
Sep 24, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This was
linked to
issues
May 8, 2025
mgazeel
reviewed
May 8, 2025
mgazeel
reviewed
May 8, 2025
mgazeel
reviewed
May 8, 2025
mgazeel
reviewed
May 8, 2025
mgazeel
reviewed
May 8, 2025
mgazeel
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Version 1.2.0: Sponge Gourd
tl;dr:
gourd analyseredone, now supports:breaking changes:
maintainer changes:
ColumnGenerator(s)qol changes:
still todo:
fix divide by zero error in default metrics accumulator
write new gourd analyse user-end documentation
write col gen maintainer docs
write config() integration test maintainer docs
create issues for additional integration test scenarios desired (multi-step pipelines, more extensive gourd analyse testing, etc)
update version in code & docs
merge new afterscript documentation
write new postprocessing documentation (using
next) & tutorialdocumentation for slurm.{mail_type, begin, mail_user, additional_args}
for every value in constants.rs, mention the lines in documentation that need to be updated when the constant changes.
merge Simplified afterscripts #41
improve help for
SLURM versioning failederror in cliremove mentions of set_limits in documentation
...
after everything else is done, update
docs/maintainer/version-history/section.tex