Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency array bug #332

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Fix dependency array bug #332

merged 1 commit into from
Aug 11, 2023

Conversation

orhoj
Copy link
Contributor

@orhoj orhoj commented Aug 9, 2023

Purpose

Fix an issue where external data was fetched multiple times for no reason.

Changes

  • Made the verifiable credentials atom into an AsyncWrapper to correctly handle the loading state.
  • Fixed a type issue in a storybook story.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@orhoj orhoj merged commit 10da432 into feature/web3-id Aug 11, 2023
4 checks passed
@orhoj orhoj deleted the fix-dependency-array-issue branch August 11, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shjortConcordium shjortConcordium shjortConcordium approved these changes

Assignees

@orhoj orhoj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orhoj @shjortConcordium