Background color and update fixes #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added translations for the status values.
Comment on lines
+30
to
+32
| getVerifiableCredentialStatus(client, credential.id) | ||
| .then(setStatus) | ||
| .catch(() => setStatus(VerifiableCredentialStatus.Pending)); |
There was a problem hiding this comment.
I though this would fix the fact that credentials are not shown until they are on chain, but it doesn't seem to 🤔
(Should it?)
There was a problem hiding this comment.
It should and I thought it did. It's a quick-fix as we should probably differentiate "real" errors and just waiting for it to arrive on chain, but this works for now. Or so I thought.
There was a problem hiding this comment.
It is because the credentialEntry is not available either.
shjortConcordium
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adjust to changes to metadata format and fix some bugs.
Changes
background_colortobackgroundColor.Checklist
hard-to-understand areas.