Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change from json-rpc to grpc #339

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Change from json-rpc to grpc #339

merged 2 commits into from
Aug 16, 2023

Conversation

DOBEN
Copy link
Member

@DOBEN DOBEN commented Aug 16, 2023 •
edited
Loading

Purpose

  • JSON-RPC is deprecated and will be eventually removed from all our libraries. This PR migrates the eSealing dApp.

Changes

  • Replace using jsonRPC with gRPC

@DOBEN DOBEN requested review from bisgardo and abizjak August 16, 2023 13:41
bisgardo
bisgardo approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@bisgardo bisgardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/eSealing/src/utils.ts Outdated Show resolved Hide resolved
examples/eSealing/src/eSealing.tsx Outdated Show resolved Hide resolved
examples/eSealing/package.json Outdated Show resolved Hide resolved
@DOBEN DOBEN merged commit ef5b0b3 into main Aug 16, 2023
4 checks passed
@DOBEN DOBEN deleted the replace-json-rpc-with-grpc branch August 16, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bisgardo bisgardo bisgardo approved these changes

@abizjak abizjak Awaiting requested review from abizjak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DOBEN @bisgardo