Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proofs with number attributes #342

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Fix proofs with number attributes #342

merged 1 commit into from
Aug 18, 2023

Conversation

shjortConcordium
Copy link
Contributor

Purpose

Enable proofs with number attributes.

Changes

  • Handle number attributes in proofs
  • Don't crash on non-existant attributes (might be moot due to the next point)
  • Now filter credential that don't have the attribute, even if its nonMembership.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@shjortConcordium shjortConcordium merged commit a0db562 into feature/web3-id Aug 18, 2023
4 checks passed
@shjortConcordium shjortConcordium deleted the web3Id-support-numbers branch August 18, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhoj orhoj orhoj approved these changes

Assignees

@orhoj orhoj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shjortConcordium @orhoj