Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web3 ID logging #354

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Web3 ID logging #354

merged 2 commits into from
Aug 25, 2023

Conversation

orhoj
Copy link
Contributor

@orhoj orhoj commented Aug 25, 2023

Purpose

Add logging of failure events for easier debugging.

Changes

  • Added logging entry to chrome.storage. It will currently store the most recent 100 events.
  • For the development build errors are also logged to console.
  • Added logging to the Web3 ID error scenarios I could find where we wanted it to be logged.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@orhoj orhoj merged commit 3b33356 into feature/web3-id Aug 25, 2023
4 checks passed
@orhoj orhoj deleted the web3-id-logging branch August 25, 2023 14:15
@orhoj orhoj restored the web3-id-logging branch August 25, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shjortConcordium shjortConcordium shjortConcordium approved these changes

Assignees

@orhoj orhoj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orhoj @shjortConcordium