Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import popup #356

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Fix import popup #356

merged 6 commits into from
Aug 28, 2023

Conversation

orhoj
Copy link
Contributor

@orhoj orhoj commented Aug 25, 2023

Purpose

Fix import flow on Windows and macOS (and improve on the race condition).

Changes

  • Wait for the popup to close before opening the import window.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@orhoj
Wait for extension to be closed
ade5e0e 
This is a hacky fix that awaits the popup to close before continuing with import.
@orhoj
Merge branch 'feature/web3-id' of github.com:Concordium/concordium-br…
0615c6c 
…owser-wallet into fix-import-popup
@orhoj
Improve the documentation
8ce3720
@orhoj
Update CHANGELOG
b3a38fc
@orhoj orhoj merged commit 80e7d8a into feature/web3-id Aug 28, 2023
4 checks passed
@orhoj orhoj deleted the fix-import-popup branch August 28, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shjortConcordium shjortConcordium shjortConcordium approved these changes

Assignees

@orhoj orhoj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orhoj @shjortConcordium