Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent adding a credential with attributes not listed in schema #361

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Prevent adding a credential with attributes not listed in schema #361

merged 4 commits into from
Aug 29, 2023

Conversation

orhoj
Copy link
Contributor

@orhoj orhoj commented Aug 28, 2023

Purpose

Improve schema validation when adding a Web3 ID credential.

Changes

  • Now checks that the credential to be added does not contain any attribute not mentioned in the schema.
  • Added a missing CHANGELOG entry from another PR.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@orhoj orhoj mentioned this pull request Aug 28, 2023
Merged
5 tasks
@orhoj orhoj merged commit 4a12187 into feature/web3-id Aug 29, 2023
4 checks passed
@orhoj orhoj deleted the improve-schema-validation branch August 29, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shjortConcordium shjortConcordium shjortConcordium approved these changes

Assignees

@orhoj orhoj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orhoj @shjortConcordium