This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
useContractSchemaRpc: Parse schema based on module version #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't change existing behavior, but it's a little more precise and provides a kind of documentation of the relationship between module and schema versions.
|
Keeping as draft until #42 is merged. |
abizjak
approved these changes
Aug 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Make fetching/parsing of contract schema more precise based on the module version information that is now exposed by the gRPC client.
This in turn also documents the relationship between module and schema versions.
Changes
Use module version to determine what custom sections to look for and add comments explaining the expected results.