This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
wallet-connectors: Remove deprecated JSON-RPC client integration #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR only prepares for the removal of the feature. It will not get merged/released until explicitly requested. |
bisgardo
changed the title
DOBEN
reviewed
Aug 15, 2023
Co-authored-by: Doris Benda <DOBEN@users.noreply.github.com>
bisgardo
commented
Aug 16, 2023
bisgardo
commented
Oct 11, 2023
orhoj
approved these changes
Oct 31, 2023
|
LGTM |
soerenbf
approved these changes
Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove support for the depreated JSON-RPC client as per this strategy.
Changes
Remove all symbols related to
WalletConnection.getJsonRpcClient.