Support protocol 7 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Victor-N-Suadicani
deleted the
vs/gos-1-support-protocol-7-api-in-the-go-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Supports the new fields in protocol 7, in particular in the AccountInfo.
Changes
Updated the GRPC API submodule to the
grpc-api/7.0tag, which supports protocol 7. Then, regenerated the protobuf code based on the new protobuf definitions. This process was previously undocumented - I've now documented how to do this in the README.Also got rid of various warnings and deprecations that were previously present in the code.
Checklist
hard-to-understand areas.