Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidying up #255

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Tidying up #255

merged 3 commits into from
Jul 31, 2023

Conversation

MilkywayPirate
Copy link
Contributor

@MilkywayPirate MilkywayPirate commented Jul 31, 2023

Purpose

Tidying up and fixing a few json deserialization bugs.

In particular MintDistribution was not properly deserialized.
Introduced some wrapper types for BLSKeys and VRFKeys which are used when generating baker keys.

The flow of baker keys also changed slightly, such that one must call BakerKeys.createBakerKeys in order to create the keys and then these must be supplied to TransactionFactory.newConfigureBaker.

BakerKeys also exposes a createBakerCredentials helper function for writing out baker credentials that a node can be configured with in order to participate in the baking committee i.e. start baking.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@MilkywayPirate MilkywayPirate merged commit 4716ff2 into main Jul 31, 2023
1 check passed
@MilkywayPirate MilkywayPirate deleted the tidying-up branch July 31, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant