Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated #284

Merged
merged 42 commits into from
Dec 12, 2023
Merged

Remove deprecated #284

merged 42 commits into from
Dec 12, 2023

Conversation

magnusbechwind
Copy link
Contributor

@magnusbechwind magnusbechwind commented Nov 29, 2023 •
edited
Loading

Purpose

Remove deprecated V1 API

Changes

Removed the Client class and all now deprecated classes. Removed JSON serialization from lots of classes, as it is no longer needed.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@magnusbechwind
Removed deprecated client and NodeInfo.
84ee4b2
@magnusbechwind
Removed deprecated BlockSummary
0733b3a
@magnusbechwind
Removed deprecated PeerStatistics and PeerStat
58230a6
@magnusbechwind
Removed unnecessary JSON parsing from BlockInfo
8ece692
@magnusbechwind
Removed unnecessary JSON parsing from ChainParameters V0 and V1
efcdb43
@magnusbechwind
Removed unnecessary JsonCreator in CryptographicParameters and remove…
b126fd9 
…d unused Value
@magnusbechwind
Removed unnecessary ModuleSource
010eca0
@magnusbechwind
Removed unnecessary PoolStatus abstract class and PassiveDelegationSt…
de18ba7 
…atus, as only BakerPoolStatus is used in V2
@magnusbechwind
Removed unnecessary Json parsing from SpecialOutcome
d974710
@magnusbechwind
Removed unnecessary TransactionStatusInBlock TransactionStatus and Tr…
25b097c 
…ansactionSummary
@magnusbechwind
Refactored Baker to contain BakerInfo
69f7b31
@magnusbechwind
Removed exceptions only thrown by the v1 client
24ef488
@magnusbechwind
Removed unnecessary Contents Value and AccountInfoTest (Only tested d…
3d32abd 
…eserialization from json). Removed Json Deserializing from various classes
@magnusbechwind
Removed unnecessary Json Deserializing from various classes
c4e74ea
@magnusbechwind
Removed unnecessary Ancestors
787d9b0
@magnusbechwind
Removed unnecessary BanNodeRequest
1279a8d
@magnusbechwind
Removed unnecessary Baker BirkParameters
372347f
@magnusbechwind
Removed unnecessary BlocksAtHeight
4cc1b2e
@magnusbechwind
Removed unnecessary JsonCreators in package blocksummary.specialoutcomes
f9d6715
@magnusbechwind
Removed unnecessary json parsing in package blocksummary.updates.keys
ca64935
@magnusbechwind
Removed unnecessary classes and json parsing in package blocksummary.…
864c523 
…updates.queues
@magnusbechwind
Removed unnecessary json parsing in ProtocolUpdate
17dff91
@magnusbechwind
Removed unnecessary json parsing in FinalizationData and Finalizer
b476855
@magnusbechwind
Removed unnecessary json parsing in Branch
0408c00
@magnusbechwind
Removed unnecessary classes and json parsing in package responses.cha…
40ed0ca 
…inparameters
@magnusbechwind
Removed unnecessary json parsing in ConsensusStatus and ProtocolVersion
bad724b
@magnusbechwind
Removed unnecessary json parsing in InstanceInfo
3cabda2
@magnusbechwind
Removed unnecessary json parsing in ModuleRef
dba94ed
@magnusbechwind
Removed unnecessary class BakingStatus
0a53537
@magnusbechwind
Merged Peer into PeerInfo as Peer was no longer needed as a standalon…
3e7cacb 
…e class.
@magnusbechwind magnusbechwind linked an issue Nov 29, 2023 that may be closed by this pull request
Remove V1 API #281
Closed
@magnusbechwind magnusbechwind marked this pull request as ready for review November 29, 2023 15:20
MilkywayPirate
MilkywayPirate reviewed Dec 7, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
MilkywayPirate
MilkywayPirate reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@MilkywayPirate MilkywayPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we can be a bit more helpful in the changelog for consumers, but otherwise I think it's fine to clean up these things.

MilkywayPirate
MilkywayPirate approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@MilkywayPirate MilkywayPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

CHANGELOG.md Outdated Show resolved Hide resolved
@magnusbechwind @MilkywayPirate
Update CHANGELOG.md
fc88696 
Co-authored-by: Emil Lai <39825288+EmilLa1@users.noreply.github.com>
@magnusbechwind magnusbechwind merged commit 7162b04 into main Dec 12, 2023
1 check passed
@magnusbechwind magnusbechwind deleted the remove-deprecated branch December 12, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilkywayPirate MilkywayPirate MilkywayPirate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove V1 API
2 participants
@magnusbechwind @MilkywayPirate