Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key derivation #293

Merged
merged 17 commits into from
Jan 17, 2024
Merged

Key derivation #293

merged 17 commits into from
Jan 17, 2024

Conversation

orhoj
Copy link
Contributor

@orhoj orhoj commented Jan 5, 2024

Purpose

Add a class ConcordiumHdWallet to perform key derivation.

Changes

  • Added ConcordiumHdWallet Java class used to derive Concordium keys and randomness.
  • Updated Rust JNI library to access key derivation functionality from concordium base.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@orhoj orhoj marked this pull request as draft January 5, 2024 12:57
MilkywayPirate
MilkywayPirate reviewed Jan 8, 2024
View reviewed changes
Copy link
Contributor

@MilkywayPirate MilkywayPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! GJ.

I have a few comments on the java parts for now, I'll look into the rust parts asap.

concordium-sdk/src/main/java/com/concordium/sdk/crypto/wallet/WordLists.java Outdated Show resolved Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/crypto/wallet/Network.java Outdated Show resolved Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/crypto/wallet/WordLists.java Show resolved Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/HexadecimalValidator.java Outdated Show resolved Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/crypto/wallet/ConcordiumHdWallet.java Show resolved Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/crypto/CryptoJniNative.java Outdated Show resolved Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/crypto/wallet/ConcordiumHdWallet.java Outdated Show resolved Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/crypto/wallet/ConcordiumHdWallet.java Outdated Show resolved Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/crypto/wallet/ConcordiumHdWallet.java Outdated Show resolved Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/crypto/wallet/ConcordiumHdWallet.java Outdated Show resolved Hide resolved
MilkywayPirate
MilkywayPirate reviewed Jan 8, 2024
View reviewed changes
Copy link
Contributor

@MilkywayPirate MilkywayPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few minor comments.

crypto-jni/src/lib.rs Show resolved Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/crypto/wallet/ConcordiumHdWallet.java Show resolved Hide resolved
crypto-jni/src/lib.rs Outdated Show resolved Hide resolved
@orhoj orhoj marked this pull request as ready for review January 16, 2024 11:25
MilkywayPirate
MilkywayPirate approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@MilkywayPirate MilkywayPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Base automatically changed from android-sdk to main January 16, 2024 11:59
@orhoj orhoj merged commit c44c716 into main Jan 17, 2024
2 checks passed
@orhoj orhoj deleted the hd-wallet branch January 17, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilkywayPirate MilkywayPirate MilkywayPirate approved these changes

@shjortConcordium shjortConcordium Awaiting requested review from shjortConcordium

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orhoj @MilkywayPirate