Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cis2 #304

Merged
merged 39 commits into from
Feb 14, 2024
Merged

Cis2 #304

merged 39 commits into from
Feb 14, 2024

Conversation

MilkywayPirate
Copy link
Contributor

@MilkywayPirate MilkywayPirate commented Feb 1, 2024

Purpose

Address #216 by introducing a Cis2Client for interfacing with CIS2 compliant smart contracts.

Changes

  • Introduced a Cis2Client for interfacing with a CIS2 compliant smart contract
  • Support for deserializing a smart contract update transaction
  • Fix a bug where smart contract invocations included the parameters in a serialized format where the length of the parameter was prepended (as is the case for smart contract updates/initializations)
  • Fix such that reject reasons are being parsed into the resulting AccountTransactionDetails object.
  • Snapshotted the version as it was not done since the last release.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@MilkywayPirate MilkywayPirate marked this pull request as ready for review February 5, 2024 20:42
Copy link
Contributor

@shjortConcordium shjortConcordium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could make sense to have examples for some of the CIS-2 client methods, like we do for in the JS SDK?
https://github.com/Concordium/concordium-node-sdk-js/tree/main/examples/nodejs/cis2

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
MilkywayPirate and others added 4 commits February 14, 2024 07:36
Co-authored-by: Aleš Bizjak <abizjak@users.noreply.github.com>
Co-authored-by: Aleš Bizjak <abizjak@users.noreply.github.com>
….java

Co-authored-by: Aleš Bizjak <abizjak@users.noreply.github.com>
@MilkywayPirate MilkywayPirate merged commit 20c837d into main Feb 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants