Fix bug where AccountInfo could fail if there were no pendingchange for a delegator or validator. #307

MilkywayPirate · 2024-02-05T09:15:57Z

Purpose

Fixed parsing of the delegator / baker stake objects
Baker and AccountDelegation now exposes Optional<PendingChange> as opposed to just
PendingChange.
Fix .equals on AccountInfo
Added a test

My code follows the style of this project.
The code compiles without warnings.
I have performed a self-review of the changes.
I have documented my code, in particular the intent of the
hard-to-understand areas.
(If necessary) I have updated the CHANGELOG.

for a delegator or validator.

concordium-sdk/src/main/java/com/concordium/sdk/ClientV2MapperExtensions.java

concordium-sdk/src/test/java/com/concordium/sdk/ClientV2GetAccountInfoTest.java

concordium-sdk/src/main/java/com/concordium/sdk/ClientV2MapperExtensions.java

Fix bug where AccountInfo could fail if there were no pendingchange

1cc2aa7

for a delegator or validator.

MilkywayPirate requested review from abizjak and magnusbechwind February 5, 2024 09:16

abizjak approved these changes Feb 5, 2024

View reviewed changes

Emil Lai added 2 commits February 5, 2024 21:19

Fix equality check for AccountInfo and test.

ad3b573

Address review comments.

2446166

MilkywayPirate self-assigned this Feb 5, 2024

MilkywayPirate merged commit f337f03 into main Feb 5, 2024
2 checks passed

MilkywayPirate deleted the pendingchange-fix branch February 5, 2024 20:50