Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convenience functions issue #272 #314

Merged
merged 18 commits into from
Mar 6, 2024
Merged

Convenience functions issue #272 #314

merged 18 commits into from
Mar 6, 2024

Conversation

magnusbechwind
Copy link
Contributor

@magnusbechwind magnusbechwind commented Feb 14, 2024 •
edited
Loading

Purpose

Adds convenience function to convert between CCDAmount, Energy and Euros.

Changes

Added class BigFraction to represent fractions with very large numerators/denominators allowing for excact conversions. Implemented conversion methods in utility class Converter.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@magnusbechwind magnusbechwind linked an issue Feb 14, 2024 that may be closed by this pull request
Convenience functions for calculating the CCDAmount from Energy #272
Closed
@magnusbechwind magnusbechwind marked this pull request as ready for review February 14, 2024 12:10
MilkywayPirate
MilkywayPirate reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@MilkywayPirate MilkywayPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job it looks good.

A few comments here and there.

concordium-sdk/src/main/java/com/concordium/sdk/Converter.java Outdated Show resolved Hide resolved
concordium-sdk/src/test/java/com/concordium/sdk/EnergyToCCDTest.java Outdated Show resolved Hide resolved
concordium-sdk/src/test/java/com/concordium/sdk/EnergyToCCDTest.java Outdated Show resolved Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/Converter.java Outdated Show resolved Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/Converter.java Outdated Show resolved Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/types/BigFraction.java Outdated Show resolved Hide resolved
@magnusbechwind
Merge branch 'main' into Energy-to-ccd
9c5d8ce 
# Conflicts:
#	CHANGELOG.md
@magnusbechwind magnusbechwind merged commit 799290f into main Mar 6, 2024
2 checks passed
@magnusbechwind magnusbechwind deleted the Energy-to-ccd branch March 6, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abizjak abizjak abizjak approved these changes

@MilkywayPirate MilkywayPirate MilkywayPirate left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convenience functions for calculating the CCDAmount from Energy
3 participants
@magnusbechwind @abizjak @MilkywayPirate