JAV-319 Support for Protocol 7

[Radiokot]

Purpose

Support Protocol 7.

Changes

• Added ProtocolVersion.V7 corresponding to Protocol version 7
• Added cooldowns list to AccountInfo
• Added availableBalance to AccountInfo
• Made optional the following BakerPoolStatus fields:
  bakerEquityCapital, delegatedCapital, delegatedCapitalCap, poolInfo
• Updated version to 7.3.0-SNAPSHOT

Checklist

• My code follows the style of this project.
• The code compiles without warnings.
• I have performed a self-review of the changes.
• I have documented my code, in particular the intent of the
  hard-to-understand areas.
• (If necessary) I have updated the CHANGELOG.

[soerenbf]

IMO looks good. You need to handle the newly added transaction events however.

Have a look at the added transaction events here: BakerEvent.DelegationRemoved and DelegationEvent.BakerRemoved

[Radiokot]

It seems that the SDK doesn't handle any events, they are only found in gRPC generated classes.

[soerenbf]

It seems that the SDK doesn't handle any events, they are only found in gRPC generated classes.

I don't understand why I cannot find the added types anywhere then? I guess the generated code is not part of the repository?

To me it looks like anything in https://github.com/Concordium/concordium-java-sdk/tree/JAV-319-protocol-7/concordium-sdk/src/main/java/com/concordium/sdk/responses contains classes which are created from the generated GRPC types, and this folder https://github.com/Concordium/concordium-java-sdk/tree/JAV-319-protocol-7/concordium-sdk/src/main/java/com/concordium/sdk/responses/transactionstatus is supposed to (I assume) have 2 extra classes for the respective events linked in my original review:

Have a look at the added transaction events here: BakerEvent.DelegationRemoved and DelegationEvent.BakerRemoved

And of course these would have to be mapped as well somewhere.. If the events are not used it seems like a lot of wasted effort was put into making the already existing conversions?

[Radiokot]

I don't understand why I cannot find the added types anywhere then? I guess the generated code is not part of the repository?

Yes, they get generated locally:

Classes under the responses package are manually written human-friendly mappings of GRPC classes involved in ClientV2 calls. The conversion between GRPC and responses is done in ClientV2MapperExtensions.

I'll take a look at transactionstatus.

[soerenbf]

Some minor inconsistencies. When they're fixed, feel free to merge 😄