Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SDK to align with Protocol 6 #58

Merged
4 commits merged into from
Aug 2, 2023
Merged

Updated SDK to align with Protocol 6 #58

4 commits merged into from
Aug 2, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 28, 2023

Purpose

Update SDK to align with new consensus protocol and hence changes done in gRPC API
Concordium/concordium-grpc-api@13e2394.

This PR at the same time prepare for release 4.0.0.

Changes

  • ConsensusInfo
    • SlotDuration is now an nullable field, only present in protocols 1-5.
    • a new field ConcordiumBftDetails is added, that is present if protocol
      version is 6 or higher
    • Bugfix: BlockLastArrivedTime was wrongly mapped from BlockLastReceivedTime.
  • BlockInfo
    • BlockSlot is nullable, and only present in protocols 1-5
    • new fields Round and Epoch that are present in protocol 6 or higher.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.

@ghost ghost requested a review from limemloh July 28, 2023 09:17
@ghost ghost mentioned this pull request Aug 1, 2023
4 tasks
@abizjak abizjak self-requested a review August 1, 2023 09:31
@ghost ghost requested review from ali-concordium and abizjak and removed request for abizjak and limemloh August 1, 2023 09:55
Copy link
Contributor

@abizjak abizjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@abizjak
Copy link
Contributor

abizjak commented Aug 2, 2023

Also an emoji 🚀 to fullfil the challenge.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/Helpers/DateAndTimeExtensions.cs Outdated Show resolved Hide resolved
src/Types/BakerPoolPendingChange.cs Outdated Show resolved Hide resolved
src/Types/ConcordiumBftDetails.cs Outdated Show resolved Hide resolved
src/Types/ConsensusInfo.cs Outdated Show resolved Hide resolved
@ghost ghost merged commit d422449 into main Aug 2, 2023
1 check passed
@ghost ghost deleted the ss/update-to-p6 branch August 2, 2023 12:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants