-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated SDK to align with Protocol 6 #58
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from limemloh
July 28, 2023 09:17
ghost
mentioned this pull request
Aug 1, 2023
4 tasks
ghost
requested review from
ali-concordium and
abizjak
and removed request for
abizjak and
limemloh
August 1, 2023 09:55
abizjak
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Also an emoji 🚀 to fullfil the challenge. |
ali-concordium
approved these changes
Aug 2, 2023
ghost
deleted the
ss/update-to-p6
branch
August 2, 2023 12:40
ali-concordium
approved these changes
Aug 2, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Update SDK to align with new consensus protocol and hence changes done in gRPC API
Concordium/concordium-grpc-api@13e2394.
This PR at the same time prepare for release 4.0.0.
Changes
ConsensusInfo
SlotDuration
is now an nullable field, only present in protocols 1-5.ConcordiumBftDetails
is added, that is present if protocolversion is 6 or higher
BlockLastArrivedTime
was wrongly mapped fromBlockLastReceivedTime
.BlockInfo
BlockSlot
is nullable, and only present in protocols 1-5Round
andEpoch
that are present in protocol 6 or higher.Checklist
hard-to-understand areas.