Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spurious reporting of baker double signing #954

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Fix spurious reporting of baker double signing #954

merged 1 commit into from
Jul 6, 2023

Conversation

td202
Copy link
Contributor

@td202 td202 commented Jul 6, 2023

Purpose

Fixes #949

Fix an issue where duplicate invalid blocks are spuriously reported as a case of double signing.

Changes

  • When double signing is detected, check that the block is actually distinct from the previous signed block.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@td202 td202 merged commit c9cb565 into main Jul 6, 2023
3 checks passed
@td202 td202 deleted the fix-949 branch July 6, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect detection of double signed rounds
3 participants