Example tools: Add support for providing memo as string #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will be CBOR encoded by the tool...
And changed transfer-client to use CCD amount instead of uCCD for consistency.
Bargsteen
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memo strings are CBOR encoded by the tool.
It was necessary to upgrade
transfer-client-directto using gRPC APIv2 for it to work with the Node. Also, the types used for amount to send and format of the key file was aligned between the two transfer tools. The new file format includes the account address, so we use that instead of passing it in the option--sender.The changes have been fully verified by sending transfers on testnet (all combinations of the memo options).