Fix integration tests should panic if error occurs #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abizjak
reviewed
Nov 22, 2023
DOBEN
force-pushed
the
fix-integration-tests
branch
from
0eb44d1 to
dd0cb68
Compare
abizjak
reviewed
Nov 22, 2023
abizjak
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Currently, pipelines don't fail when the integration test fails. E.g.
https://github.com/Concordium/concordium-rust-smart-contracts/actions/runs/6949103634/job/18906722001
This PR might also address:
Concordium/concordium-rust-smart-contracts#360
Changes
Integration tests should panic if an error occurs so CI pipeline can pick it up.