Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to deriveFromChain given a module reference when initializing a contract instance #154

Conversation

DOBEN
Copy link
Member

@DOBEN DOBEN commented Jan 23, 2024

Purpose

closes #149
Until now, people had to upload a module file at step 1 before they were able to derive values for initializing in step 2.
Now, there is a new option to derive the values in step 2 from the chain given a valid module reference.

Changes

  • Simplified interactions between Step 1 and Step 2. Only the moduleRefrence is now a shared state between the two boxes.
  • Add option to deriveFromChain given a module reference in Step 2.

@DOBEN DOBEN force-pushed the enable-initializing-new-smart-contract-from-the-existing-module-reference branch from 8ac686b to 27090c3 Compare February 8, 2024 14:33
@DOBEN DOBEN force-pushed the enable-initializing-new-smart-contract-from-the-existing-module-reference branch from ef52653 to 7d338a9 Compare February 15, 2024 10:10
@DOBEN DOBEN changed the title WIP: Add option to deriveFromChain given a module reference Feb 15, 2024
@DOBEN DOBEN changed the title Add option to deriveFromChain given a module reference Add option to deriveFromChain given a module reference when initilizing a contract instance Feb 15, 2024
@DOBEN DOBEN changed the title Add option to deriveFromChain given a module reference when initilizing a contract instance Add option to deriveFromChain given a module reference when initializing a contract instance Feb 15, 2024
@DOBEN DOBEN requested review from abizjak and soerenbf February 15, 2024 11:58
front-end-tools/src/constants.ts Outdated Show resolved Hide resolved
front-end-tools/src/writing_to_blockchain.ts Outdated Show resolved Hide resolved
front-end-tools/src/writing_to_blockchain.ts Outdated Show resolved Hide resolved
front-end-tools/src/writing_to_blockchain.ts Outdated Show resolved Hide resolved
front-end-tools/src/components/InitComponent.tsx Outdated Show resolved Hide resolved
front-end-tools/src/components/InitComponent.tsx Outdated Show resolved Hide resolved
@DOBEN DOBEN force-pushed the enable-initializing-new-smart-contract-from-the-existing-module-reference branch from 9c61e14 to eab342c Compare February 16, 2024 12:22
@DOBEN DOBEN requested a review from abizjak February 16, 2024 15:51
Copy link
Contributor

@abizjak abizjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally Soren would also have a look, but it looks OK to me.

Copy link
Contributor

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😄

front-end-tools/src/components/DeployComponent.tsx Outdated Show resolved Hide resolved
front-end-tools/src/components/InitComponent.tsx Outdated Show resolved Hide resolved
@DOBEN DOBEN merged commit 6daa288 into main Feb 20, 2024
3 checks passed
@DOBEN DOBEN deleted the enable-initializing-new-smart-contract-from-the-existing-module-reference branch February 20, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants