-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to deriveFromChain
given a module reference when initializing a contract instance
#154
Merged
DOBEN
merged 11 commits into
main
from
enable-initializing-new-smart-contract-from-the-existing-module-reference
Feb 20, 2024
Merged
Add option to deriveFromChain
given a module reference when initializing a contract instance
#154
DOBEN
merged 11 commits into
main
from
enable-initializing-new-smart-contract-from-the-existing-module-reference
Feb 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOBEN
force-pushed
the
enable-initializing-new-smart-contract-from-the-existing-module-reference
branch
from
February 8, 2024 14:33
8ac686b
to
27090c3
Compare
DOBEN
force-pushed
the
enable-initializing-new-smart-contract-from-the-existing-module-reference
branch
from
February 15, 2024 10:10
ef52653
to
7d338a9
Compare
DOBEN
changed the title
Add option to
Add option to Feb 15, 2024
deriveFromChain
given a module reference deriveFromChain
given a module reference when initilizing a contract instance
DOBEN
changed the title
Add option to
Add option to Feb 15, 2024
deriveFromChain
given a module reference when initilizing a contract instancederiveFromChain
given a module reference when initializing a contract instance
abizjak
reviewed
Feb 16, 2024
DOBEN
force-pushed
the
enable-initializing-new-smart-contract-from-the-existing-module-reference
branch
from
February 16, 2024 12:22
9c61e14
to
eab342c
Compare
…y are automatically refreshed
abizjak
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally Soren would also have a look, but it looks OK to me.
soerenbf
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 😄
DOBEN
deleted the
enable-initializing-new-smart-contract-from-the-existing-module-reference
branch
February 20, 2024 10:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
closes #149
Until now, people had to upload a module file at step 1 before they were able to derive values for initializing in step 2.
Now, there is a new option to derive the values in step 2 from the chain given a valid module reference.
Changes
deriveFromChain
given a module reference in Step 2.