Use wasm opt #193
Open
Use wasm opt #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOBEN
approved these changes
Jan 15, 2025
td202
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Currently this produces a linker error on Windows that we probably need to figure out how to resolve:
= note: C:/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/13.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\Thomas\Documents\concordium\concordium-smart-contract-tools\cargo-concordium\target\release\deps\libwasm_opt_sys-43fb2d296010354e.rlib(33c8a920b262e069-wasm-validator.o):wasm-validator:(.text$_ZN4wasm4Pass13runOnFunctionEPNS_6ModuleEPNS_8FunctionE+0x0): multiple definition of `wasm::Pass::runOnFunction(wasm::Module*, wasm::Function*)'; C:\Users\Thomas\Documents\concordium\concordium-smart-contract-tools\cargo-concordium\target\release\deps\libwasm_opt_cxx_sys-29cb707347905cdf.rlib(aeea60e054e9ce5c-lib.rs.o):lib.rs.cc:(.text$_ZN4wasm4Pass13runOnFunctionEPNS_6ModuleEPNS_8FunctionE[_ZN4wasm4Pass13runOnFunctionEPNS_6ModuleEPNS_8FunctionE]+0x0): first defined here␍
C:/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/13.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\Thomas\Documents\concordium\concordium-smart-contract-tools\cargo-concordium\target\release\deps\libwasm_opt_sys-43fb2d296010354e.rlib(33c8a920b262e069-wasm-validator.o):wasm-validator:(.text$_ZN4wasm4Pass3runEPNS_6ModuleE+0x0): multiple definition of `wasm::Pass::run(wasm::Module*)'; C:\Users\Thomas\Documents\concordium\concordium-smart-contract-tools\cargo-concordium\target\release\deps\libwasm_opt_cxx_sys-29cb707347905cdf.rlib(aeea60e054e9ce5c-lib.rs.o):lib.rs.cc:(.text$_ZN4wasm4Pass3runEPNS_6ModuleE[_ZN4wasm4Pass3runEPNS_6ModuleE]+0x0): first defined here␍
C:/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/13.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\Thomas\Documents\concordium\concordium-smart-contract-tools\cargo-concordium\target\release\deps\libwasm_opt_sys-43fb2d296010354e.rlib(33c8a920b262e069-wasm-validator.o):wasm-validator:(.text$_ZN4wasm4Pass6createEv+0x0): multiple definition of `wasm::Pass::create()'; C:\Users\Thomas\Documents\concordium\concordium-smart-contract-tools\cargo-concordium\target\release\deps\libwasm_opt_cxx_sys-29cb707347905cdf.rlib(aeea60e054e9ce5c-lib.rs.o):lib.rs.cc:(.text$_ZN4wasm4Pass6createEv[_ZN4wasm4Pass6createEv]+0x0): first defined here␍
collect2.exe: error: ld returned 1 exit status
Comment on lines
+239
to
+242
| wasm_opt::OptimizationOptions::new_optimize_for_size() | ||
| .run(&filename, &filename) | ||
| .context("Failed running wasm_opt")?; | ||
|
|
There was a problem hiding this comment.
I'm not sure that we should optimize here. Isn't this liable to break reproducible builds?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Use
wasm-optin cargo concordium when building to workaround the issue of concordium smart contract runtime not supporting 5 bytes encodings of zero in certain places introduced in LLVM 19 (Rust 1.82)