Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate postgres code #27

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Integrate postgres code #27

merged 2 commits into from
Aug 30, 2024

Conversation

Victor-N-Suadicani
Copy link
Contributor

Purpose

The postgres feature has been removed from the SDK, so this crate (which I suppose is the only user of that feature) needs to integrate this functionality into itself, rather than relying on the SDK for it.

Changes

The postgres feature from the SDK was yanked out in Concordium/concordium-rust-sdk#204 - this PR adds this functionality back into this crate. The examples are brought over as well. The code is otherwise unchanged.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

Copy link
Contributor

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I don't see any reason why we'd need to update any of the code to conform to p7 other than updating the rust sdk to the correct version, as we don't depend on any of the API changes, and all the block item summaries (which could potentially include new baking/delegation events) are stored as JSONB

Cargo.toml Show resolved Hide resolved
@Victor-N-Suadicani Victor-N-Suadicani merged commit aa8cdf0 into main Aug 30, 2024
2 checks passed
@Victor-N-Suadicani Victor-N-Suadicani deleted the integrate_postgres branch August 30, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants