Merge pull request #6 from Concordium/fix-off-center-identity-name

Center identity name when edit icon is visible
Concordium · Mar 5, 2024 · 3f79fac · 3f79fac
2 parents afc3354 + 027b765
commit 3f79fac
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 19 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,7 @@
 - Exiting the wallet after accepting an identity verification error
 - Incorrect environment name in a private key export file for Mainnet
 - Improper handling of rejected identity verification when setting up a new wallet
+- An issue where the identity name was off-center when the edit name icon was visible
 - An issue where exporting transaction logs for an account without any transactions would be stuck at 0%
 
 ### Changed

diff --git a/app/src/main/java/com/concordium/wallet/uicore/view/IdentityView.kt b/app/src/main/java/com/concordium/wallet/uicore/view/IdentityView.kt
@@ -46,15 +46,8 @@ constructor(
     private var onChangeNameClickListener: OnChangeNameClickListener? = null
 
     fun enableChangeNameOption(identity: Identity) {
-        binding.nameTextview.compoundDrawablePadding = 20
-        val drawable = AppCompatResources.getDrawable(context, R.drawable.cryptox_ico_edit)
-        binding.nameTextview.setCompoundDrawablesRelativeWithIntrinsicBounds(
-            null,
-            null,
-            drawable,
-            null
-        )
-        binding.nameTextview.setOnClickListener {
+        binding.nameIcon.isVisible = true
+        binding.nameTextAndIcon.setOnClickListener {
             onChangeNameClickListener?.onChangeNameClicked(identity)
         }
     }

diff --git a/app/src/main/res/layout/view_identity.xml b/app/src/main/res/layout/view_identity.xml
@@ -31,18 +31,34 @@
         tools:text="@string/view_identity_status_done"
         tools:textColor="@color/ccx_status_success" />
 
-    <TextView
-        android:id="@+id/name_textview"
+    <RelativeLayout
+        android:id="@+id/name_text_and_icon"
         android:layout_width="match_parent"
-        android:layout_height="wrap_content"
+        android:layout_height="match_parent"
         android:layout_marginTop="8dp"
-        android:ellipsize="end"
-        android:gravity="center"
-        android:maxLines="1"
-        android:textAppearance="@style/CCX_Typography_H2"
-        android:textColor="@color/ccx_neutral_tint_1"
-        tools:drawableEndCompat="@drawable/cryptox_ico_edit"
-        tools:text="Identity 1" />
+        >
+
+        <TextView
+            android:id="@+id/name_textview"
+            android:layout_width="match_parent"
+            android:layout_marginHorizontal="25dp"
+            android:layout_height="wrap_content"
+            android:gravity="center"
+            android:ellipsize="end"
+            android:maxLines="1"
+            android:textAppearance="@style/CCX_Typography_H2"
+            android:textColor="@color/ccx_neutral_tint_1"
+            tools:text="Identity 1" />
+
+        <ImageView
+            android:id="@+id/name_icon"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_centerVertical="true"
+            android:layout_alignParentEnd="true"
+            android:visibility="invisible"
+            android:src="@drawable/cryptox_ico_edit"/>
+    </RelativeLayout>
 
     <TextView
         android:id="@+id/expires_textview"