WAL-57 Fix crash on testnet identity duplication #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Concordium testnet IP, the error is not JSON but a string.
When the ID verification start URL is built, it must be requested internally before passing to a browser. The final URI will be obtained after following all the redirects. It will help to detect errors such as idCredPub duplication faster.
orhoj
suggested changes
Feb 21, 2024
...a/com/concordium/wallet/ui/passphrase/recoverprocess/retrofit/IdentityProviderApiInstance.kt
Outdated
Show resolved
Hide resolved
orhoj
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This fixes wallet crashing when ID duplication is occurred on Concordium testnet IP.
It also makes the same error handling with other providers a bit nicer.
Changes
Fixed
Checklist
hard-to-understand areas.