-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two wallets #233
Merged
Merged
Two wallets #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use EncryptedData container to store ciphertext, IV and transformation. Use AES in GCM mode for futher encryptions.
We no longer re-encrypt data in DB, so the restriction is no longer relevant.
Also rename AuthenticationManager to AppAuth
* Add a comma as a separator for large numbers * Update Changelog * Update DecimalTextWatcher * Fix format GTU function
* Fix inconsistent transaction fee for invoke smart contract * Update CHANGELOG
# Conflicts: # CHANGELOG.md
# Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/com/concordium/wallet/core/notifications/UpdateNotificationsSubscriptionUseCase.kt # app/src/main/java/com/concordium/wallet/ui/MainActivity.kt # app/src/main/res/layout/fragment_welcome_promo_more.xml
# Conflicts: # CHANGELOG.md # app/src/main/java/com/concordium/wallet/core/notifications/TransactionNotificationsManager.kt # app/src/main/java/com/concordium/wallet/ui/account/accountsoverview/AccountsOverviewFragment.kt # app/src/main/res/layout/fragment_accounts_overview.xml
app/src/main/java/com/concordium/wallet/core/security/KeystoreHelper.kt
Dismissed
Show dismissed
Hide dismissed
zaiatsartem
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add ability to have two wallets of different types (1 seed, 1 file) in the same app.
Changes
Overall
In details
AppDatabase
, while the current one, wallet-wide, is calledWalletDatabase
AppDatabase
and accessible throughAppWalletRepository
Session
AppCore.session
now can be reinitialized with thestartNewSession()
methodWallet
prefix (WalletNotificationsPreferences
,WalletSendFundsPreferences
, etc.)WalletStorage
, which is accessible throughSession
and is aware of the current active wallet. Instances are no longer created in ViewModelsEncryptedData
) which holds not only the ciphertext, but also the cipher transformation and IVAuthenticationManager
and turned it intoAppAuth
, which handles app-wide password auth and encryptionEncryptionHelper
AuthPreferences
split intoAppSetupPreferences
andWalletSetupPreferences
TwoWalletsMigration
which migrates existing DB and preferences for full backward compatibilityChecklist
hard-to-understand areas.