Merge pull request #88 from Concurrency-Lab/ph-b008-remove-dictionary…

…-and-hashset PH_B008: Remove obsolete methods
Concurrency-Lab · Nov 17, 2021 · 62e0499 · 62e0499
2 parents 3aac6d9 + 54fbd0f
commit 62e0499
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/ParallelHelper.Plugin/ReleaseNotes.txt b/src/ParallelHelper.Plugin/ReleaseNotes.txt
@@ -5,6 +5,7 @@
 - Improved Analyzer: PH_B009 - Now ignores readonly fields by default
 - Improved Analyzer: PH_S032 - Now supports exception type exclusions (ArgumentException and NotImplementedException by default)
 - Improved Analyzer: PH_P007 - Now excludes private members from base types
+- Improved Analyzer: PH_B008 - No longer reports ToImmutableDictionary and ToImmutableHashSet
 
 
 ------------------

diff --git a/src/ParallelHelper/Analyzer/Bugs/LinqToCollectionOnConcurrentDictionaryAnalyzer.cs b/src/ParallelHelper/Analyzer/Bugs/LinqToCollectionOnConcurrentDictionaryAnalyzer.cs
@@ -46,8 +46,6 @@ public class LinqToCollectionOnConcurrentDictionaryAnalyzer : DiagnosticAnalyzer
     private static readonly ClassMemberDescriptor[] LinqDescriptors = {
       new ClassMemberDescriptor("System.Linq.Enumerable", "ToArray", "ToList"),
       new ClassMemberDescriptor("System.Collections.Immutable.ImmutableArray", "ToImmutableArray"),
-      new ClassMemberDescriptor("System.Collections.Immutable.ImmutableDictionary", "ToImmutableDictionary"),
-      new ClassMemberDescriptor("System.Collections.Immutable.ImmutableHashSet", "ToImmutableHashSet"),
       new ClassMemberDescriptor("System.Collections.Immutable.ImmutableList", "ToImmutableList"),
     };
 

diff --git a/src/ParallelHelper/ParallelHelper.csproj b/src/ParallelHelper/ParallelHelper.csproj
@@ -21,7 +21,8 @@
 - Improved Analyzer: PH_B004 - Now only respects the while-loop's condition
 - Improved Analyzer: PH_B009 - Now ignores readonly fields by default
 - Improved Analyzer: PH_S032 - Now supports exception type exclusions (ArgumentException and NotImplementedException by default)
-- Improved Analyzer: PH_P007 - Now excludes private members from base types</PackageReleaseNotes>
+- Improved Analyzer: PH_P007 - Now excludes private members from base types
+- Improved Analyzer: PH_B008 - No longer reports ToImmutableDictionary and ToImmutableHashSet</PackageReleaseNotes>
     <Copyright>Copyright (C) 2019 - 2021  Christoph Amrein, Concurrency Lab, Eastern Switzerland University of Applied Sciences, Switzerland</Copyright>
     <PackageTags>C#, Parallel, Asynchronous, Concurrency, Bugs, Best Practices, TPL, Task, QC, Static Analysis, async, await</PackageTags>
     <NoPackageAnalysis>true</NoPackageAnalysis>