Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #454 -- Add the use of ECDSA signatures for allowlists and airdrops to gas optimization. #662

Closed

Conversation

jackleeio
Copy link
Contributor

@jackleeio jackleeio commented Jul 14, 2024

Pre-flight checklist


This change is Reviewable

Copy link

vercel bot commented Jul 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
conflux-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2024 11:06am

Copy link
Collaborator

@darwintree darwintree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to list the article in the gas optimization part and current version will make the content confusing. And instead, it can be a good example showing how to verify signatures in solidity.

Will respond later for which folder would be best to place the modified article in

@darwintree
Copy link
Collaborator

I think this article can be put into https://www.confluxdocs.com/docs/category/tutorials-1 as espace developing tutorial for onchain signature verification. And the comparison between signture verification and mercle root can be removed.

This article can also be put into core space tutorial but may need more verification because in core space the recovered address and the actual address may differ

@jackleeio
Copy link
Contributor Author

Okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants