Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix markdown formatter for telegram notification #64

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Fix markdown formatter for telegram notification #64

merged 1 commit into from
Dec 26, 2024

Conversation

wanliqun
Copy link
Contributor

@wanliqun wanliqun commented Dec 26, 2024 •
edited by boqiu
Loading

  • Always convert context field value to string before pipeline operations.

This change is Reviewable

@wanliqun
Fix markdown formatter for telegram notification
30e3782 
- Always convert context field value to string before pipeline
@wanliqun wanliqun requested a review from boqiu December 26, 2024 04:06
boqiu
boqiu approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@boqiu boqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wanliqun)

@wanliqun wanliqun merged commit c0748b4 into main Dec 26, 2024
2 checks passed
@wanliqun wanliqun deleted the fix-telegram-markdown-formatter branch December 26, 2024 06:51
@wanliqun wanliqun mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boqiu boqiu boqiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wanliqun @boqiu