Skip to content

Conversation

@Galoretka
Copy link
Contributor

@Galoretka Galoretka commented Oct 20, 2025

  • Delete unreachable gate nil-checks and the if gate != nil wrapper in SolveInTestEngine; gkrgates.Get panics on missing gates, so these branches could never execute.
  • Remove the no-op continue in the preparatory loop and drop the unused loop variable.

Note

Streamlines SolveInTestEngine by removing dead gate nil-checks/conditional evaluation and simplifying the circuit initialization loop.

  • gkrapi:
    • std/gkrapi/testing.go (SolveInTestEngine):
      • Remove redundant gate == nil checks and the if gate != nil wrapper; always evaluate gate after retrieval and verification.
      • Simplify initialization loop over api.toStore.Circuit: drop unused loop variable and the no-op continue.

Written by Cursor Bugbot for commit e6b4dcd. This will update automatically on new commits. Configure here.

@ivokub ivokub added feat: gkr PRs related to GKR src: community Community originating PRs and issues labels Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: gkr PRs related to GKR src: community Community originating PRs and issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants