Typo and bug fixes for the ACC instruction family
#462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- more shorthands, fewer [ stack/DEC_FLAG k ]'s and [ stack/STACK_ITEM_VALUE k ]'s - boolean flag per instruction - using the account-instruction---bla convention - constants for row offsets - splitting of constraints - bug-fix: SELFBALANCE was receiving the wrong value - bug-fix: several shorthands were missing shifts ... !
OlivierBBB
commented
Oct 17, 2024
|
|
||
| (defun (account-instruction---no-trimming) (- stack/ACC_FLAG (account-instruction---touches-foreign-account))) |
There was a problem hiding this comment.
removed the no-trimming shorthand in favour of the touches-current-account shorthand
OlivierBBB
commented
Oct 17, 2024
| (account-turn-on-warmth ROW_OFFSET___ACC_FAMILY___ACCOUNT_READING_ROW) | ||
| (account-same-marked-for-selfdestruct ROW_OFFSET___ACC_FAMILY___ACCOUNT_READING_ROW) | ||
| (DOM-SUB-stamps---standard ROW_OFFSET___ACC_FAMILY___ACCOUNT_READING_ROW 0) | ||
| (read-context-data ROFF_ACC___CONTEXT_ROW CONTEXT_NUMBER) |
There was a problem hiding this comment.
Using constant for 1
OlivierBBB
commented
Oct 17, 2024
| (if-not-zero (account-instruction---is-SELFBALANCE) | ||
| (begin | ||
| (eq! (account-instruction---result-hi) 0) | ||
| (eq! (account-instruction---result-lo) (account-instruction---current-balance))))) |
There was a problem hiding this comment.
Splitting of the account-instruction-value-constraints constraint and using shorthands to keep things concrete.
OlivierBBB
commented
Oct 17, 2024
| (if-not-zero (- 1 (account-instruction-decoded-flags-sum)) | ||
| (begin | ||
| (eq! [ stack/STACK_ITEM_VALUE_HI 4 ] 0) | ||
| (eq! [ stack/STACK_ITEM_VALUE_LO 4 ] (shift account/CODE_SIZE 2)))))) |
There was a problem hiding this comment.
Bug fix. We were using the code size rather than the balance as the return value of SELFBALANCE.
OlivierBBB
commented
Oct 17, 2024
| (defun (account-instruction---account-address-lo) (shift context/ACCOUNT_ADDRESS_LO ROFF_ACC___CONTEXT_ROW)) | ||
| (defun (account-instruction---byte-code-address-hi) (shift context/BYTE_CODE_ADDRESS_HI ROFF_ACC___CONTEXT_ROW)) | ||
| (defun (account-instruction---byte-code-address-lo) (shift context/BYTE_CODE_ADDRESS_LO ROFF_ACC___CONTEXT_ROW)) | ||
| (defun (account-instruction---foreign-address-warmth) (shift account/WARMTH ROFF_ACC___ACCOUNT_DOING_ROW)) |
There was a problem hiding this comment.
Bug fix. These shorthands for values in context/ or account/ rows were missing a shift !
|
@letypequividelespoubelles all modifications that matter have a comment. |
OlivierBBB
changed the title
ACC instruction family
OlivierBBB
changed the title
ACC instruction familyACC instruction family
- splitting of constraints according to foreign-address-opcode or current-address-opcode - updated NSR constraints - added vanishing constraints for account/ROM_LEX_FLAG's - renaming of constraints
letypequividelespoubelles
approved these changes
Oct 18, 2024
| (defun (account-instruction---is-EXTCODESIZE) [ stack/DEC_FLAG 2 ] ) | ||
| (defun (account-instruction---is-EXTCODEHASH) [ stack/DEC_FLAG 3 ] ) | ||
| (defun (account-instruction---is-CODESIZE) [ stack/DEC_FLAG 4 ] ) ;; "" | ||
| (defun (account-instruction---is-SELFBALANCE) (- 1 |
There was a problem hiding this comment.
for clarity, maybe better (- 1 (+ _sum shorthands)) ? instead of (- 1 \sum shorthands)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ stack/DEC_FLAG k ]'s and[ stack/STACK_ITEM_VALUE k ]'saccount-instruction---blaconventionaccount/ROM_LEX_FLAG = 0whenever possibleNSRof instructions that touch a current account (CODESIZE,SELFBALANCE)SELFBALANCEwas receiving the wrong valueshift's ... !