Reduced size of GAS_CUMULATIVE, GAS_LEFTOVER, REFUND_COUNTER_FINAL, REFUND_COUNTER, REFUND_EFFECTIVE
#841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EFUND_COUNTER, REFUND_EFFECTIVE
OlivierBBB
approved these changes
Dec 1, 2025
Collaborator
OlivierBBB
left a comment
OlivierBBB
left a comment
There was a problem hiding this comment.
LGTM. Are there similar changes to apply to the zkASM-ified GAS module ?
letypequividelespoubelles
requested changes
Dec 2, 2025
Collaborator
letypequividelespoubelles
left a comment
letypequividelespoubelles
left a comment
There was a problem hiding this comment.
why putting i64 where you could have less ? block gas is cap at 2000000000 for linea and tx GAs since Osaka, so ...
| ( REFUND_EFFECTIVE :i128 ) | ||
| ( GAS_LEFTOVER :i64 ) | ||
| ( REFUND_COUNTER_FINAL :i64 ) | ||
| ( REFUND_EFFECTIVE :i64 ) |
Collaborator
There was a problem hiding this comment.
refund is cap by tx ax gas, so i25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Downsizes gas-related columns from i128 to i64 across cancun, osaka, prague, london, and shanghai schemas.
txndata/{cancun,osaka,prague}/columns/common.lisp:GAS_CUMULATIVEtype reduced fromi128toi64.txndata/{cancun,osaka,prague}/columns/hub_view.lisp:GAS_LEFTOVER,REFUND_COUNTER_FINAL,REFUND_EFFECTIVEtypes reduced fromi128toi64.txndata/{london,shanghai}/columns.lisp:GAS_LEFTOVER,REFUND_COUNTER,REFUND_EFFECTIVE,GAS_CUMULATIVEtypes reduced fromi128toi64.Written by Cursor Bugbot for commit 2108ce8. This will update automatically on new commits. Configure here.