Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3822 rejected transaction api service #101

Merged
merged 66 commits into from
Oct 22, 2024

Conversation

jonesho
Copy link
Contributor

@jonesho jonesho commented Sep 25, 2024

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jonesho jonesho self-assigned this Sep 25, 2024
Copy link

github-actions bot commented Sep 25, 2024

Delta Summary - Kotlin Code Coverage

Generated on: 10/03/2024 - 08:37
Description Previous Current Delta
Coverage date: 10/03/2024 - 08:37 10/03/2024 - 08:37
Tag: 651_11157913743 651_11157913743
Line coverage: 27.1% 27.1% 0.0%
Covered lines: 25877 25877 0
Coverable lines: 95371 95371 0
Total lines: 136038 136038 0
Branch coverage: 10.4% 10.4% 0.0%
Covered branches: 5566 5566 0
Total branches: 53031 53031 0
Method coverage: Feature is only available for sponsors

@jonesho jonesho requested a review from jpnovais September 25, 2024 17:45
@jonesho jonesho force-pushed the 3822-rejected-transaction-api-service branch from 48c374d to 2bba6d0 Compare September 26, 2024 05:36
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.73%. Comparing base (303e581) to head (69af199).

Files with missing lines Patch % Lines
...lin/net/consensys/zkevm/persistence/db/DbHelper.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #101      +/-   ##
============================================
- Coverage     70.57%   68.73%   -1.84%     
- Complexity     1059     1072      +13     
============================================
  Files           291      257      -34     
  Lines         11960    11062     -898     
  Branches       1103      893     -210     
============================================
- Hits           8441     7604     -837     
+ Misses         3039     2978      -61     
  Partials        480      480              
Flag Coverage Δ
hardhat ?
kotlin 68.73% <95.23%> (+0.47%) ⬆️
Files with missing lines Coverage Δ
...in/kotlin/net/consensys/zkevm/persistence/db/Db.kt 100.00% <100.00%> (ø)
...nsensys/zkevm/persistence/db/PersistenceRetryer.kt 100.00% <100.00%> (ø)
...ys/zkevm/persistence/db/PostgresHelperFunctions.kt 100.00% <ø> (ø)
...t/consensys/zkevm/persistence/db/SQLQueryLogger.kt 40.00% <ø> (ø)
...otlin/net/consensys/linea/metrics/MetricsFacade.kt 100.00% <100.00%> (ø)
...lin/net/consensys/zkevm/persistence/db/DbHelper.kt 55.26% <0.00%> (ø)

... and 40 files with indirect coverage changes

@jonesho jonesho force-pushed the 3822-rejected-transaction-api-service branch from 2bba6d0 to a6f95fa Compare September 26, 2024 07:32
@jonesho jonesho force-pushed the 3822-rejected-transaction-api-service branch 3 times, most recently from 2309502 to e29b83a Compare October 3, 2024 07:06
@jonesho jonesho force-pushed the 3822-rejected-transaction-api-service branch 4 times, most recently from 235df48 to f1492c2 Compare October 9, 2024 13:01
.github/workflows/main.yml Outdated Show resolved Hide resolved
@jonesho jonesho requested a review from jpnovais October 9, 2024 15:34
@jonesho jonesho force-pushed the 3822-rejected-transaction-api-service branch 3 times, most recently from d227ddf to 796aa7c Compare October 14, 2024 17:44
@jonesho jonesho had a problem deploying to docker-build-and-e2e October 14, 2024 17:45 — with GitHub Actions Failure
@jonesho jonesho had a problem deploying to docker-build-and-e2e October 14, 2024 17:50 — with GitHub Actions Failure
@jonesho jonesho temporarily deployed to docker-build-and-e2e October 14, 2024 17:54 — with GitHub Actions Inactive
@jonesho jonesho had a problem deploying to docker-build-and-e2e October 14, 2024 18:17 — with GitHub Actions Failure
@jonesho jonesho temporarily deployed to docker-build-and-e2e October 14, 2024 18:26 — with GitHub Actions Inactive
@jonesho jonesho temporarily deployed to docker-build-and-e2e October 15, 2024 04:09 — with GitHub Actions Inactive
@jonesho jonesho force-pushed the 3822-rejected-transaction-api-service branch from 1c89f4a to dda0b00 Compare October 16, 2024 17:55
@jonesho jonesho temporarily deployed to docker-build-and-e2e October 16, 2024 17:56 — with GitHub Actions Inactive
@jonesho jonesho temporarily deployed to docker-build-and-e2e October 17, 2024 05:49 — with GitHub Actions Inactive
@jonesho jonesho force-pushed the 3822-rejected-transaction-api-service branch from 255170a to 1d6d977 Compare October 21, 2024 18:18
@jonesho jonesho temporarily deployed to docker-build-and-e2e October 21, 2024 18:19 — with GitHub Actions Inactive
jpnovais
jpnovais previously approved these changes Oct 21, 2024
@jonesho jonesho temporarily deployed to docker-build-and-e2e October 22, 2024 05:37 — with GitHub Actions Inactive
@jonesho jonesho requested a review from jpnovais October 22, 2024 05:57
@jonesho jonesho temporarily deployed to docker-build-and-e2e October 22, 2024 06:11 — with GitHub Actions Inactive
@jonesho jonesho temporarily deployed to docker-build-and-e2e October 22, 2024 07:04 — with GitHub Actions Inactive
@jonesho jonesho temporarily deployed to docker-build-and-e2e October 22, 2024 07:33 — with GitHub Actions Inactive
@jonesho jonesho merged commit fad0db4 into main Oct 22, 2024
22 checks passed
@jonesho jonesho deleted the 3822-rejected-transaction-api-service branch October 22, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants