Skip to content

Feat: Update Linea Besu package to latest Besu and plugin versions #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 10, 2025

Conversation

fab-10
Copy link
Collaborator

@fab-10 fab-10 commented Jun 17, 2025

Related to #1115

Updated Besu and plugins to latest version, with support for the limitless prover.

Disable parallel tx processing in Besu until it is fully supported by Linea, since it is creating concurrency issues when used with the Shomei plugin and the Tracer.

Removed also the publication of the jar, since only the zip is needed now.

NOTE: if you wonder why in some places Xbonsai-parallel-tx-processing-enabled=false is used, while in other bonsai-parallel-tx-processing-enabled=false is used, it is because the former is compatible also with the previous version of Besu so it must be used for tests that will be updated only when the new Linea Besu Package is released after this PR is merged, at that point we can aligned the options to only used the new version.

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@fab-10 fab-10 had a problem deploying to docker-build-and-e2e June 17, 2025 15:16 — with GitHub Actions Error
@fab-10 fab-10 force-pushed the feat/sequencer-use-distribution-artifact branch from 5b6690d to 6e59d28 Compare June 17, 2025 15:21
@fab-10 fab-10 temporarily deployed to docker-build-and-e2e June 17, 2025 15:22 — with GitHub Actions Inactive
@fab-10 fab-10 marked this pull request as draft June 17, 2025 16:01
@fab-10 fab-10 force-pushed the feat/sequencer-use-distribution-artifact branch from 6e59d28 to 4dcb0ae Compare June 18, 2025 07:26
@fab-10 fab-10 had a problem deploying to docker-build-and-e2e June 18, 2025 07:26 — with GitHub Actions Error
@fab-10 fab-10 force-pushed the feat/sequencer-use-distribution-artifact branch from 4dcb0ae to 3218347 Compare June 18, 2025 14:19
@fab-10 fab-10 had a problem deploying to docker-build-and-e2e June 18, 2025 14:19 — with GitHub Actions Error
@fab-10 fab-10 force-pushed the feat/sequencer-use-distribution-artifact branch from 3218347 to fb3c521 Compare June 18, 2025 14:50
@fab-10 fab-10 had a problem deploying to docker-build-and-e2e June 18, 2025 14:51 — with GitHub Actions Error
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.58%. Comparing base (30e1453) to head (fdf22ce).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1173   +/-   ##
=========================================
  Coverage     65.58%   65.58%           
  Complexity     1402     1402           
=========================================
  Files           361      361           
  Lines         14039    14039           
  Branches       1345     1345           
=========================================
  Hits           9208     9208           
  Misses         4249     4249           
  Partials        582      582           
Flag Coverage Δ *Carryforward flag
hardhat 99.27% <ø> (ø) Carriedforward from de6edc1
kotlin 63.09% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fab-10 fab-10 force-pushed the feat/sequencer-use-distribution-artifact branch from fb3c521 to 5bf9493 Compare June 18, 2025 15:20
@fab-10 fab-10 had a problem deploying to docker-build-and-e2e June 18, 2025 15:21 — with GitHub Actions Error
@fab-10 fab-10 force-pushed the feat/sequencer-use-distribution-artifact branch from 5bf9493 to 3aa30a9 Compare June 19, 2025 10:04
@fab-10 fab-10 had a problem deploying to docker-build-and-e2e June 19, 2025 10:05 — with GitHub Actions Error
@fab-10 fab-10 force-pushed the feat/sequencer-use-distribution-artifact branch from 3aa30a9 to d1937fc Compare June 20, 2025 12:52
@fab-10 fab-10 had a problem deploying to docker-build-and-e2e June 20, 2025 12:52 — with GitHub Actions Error
@fab-10 fab-10 had a problem deploying to docker-build-and-e2e June 20, 2025 15:33 — with GitHub Actions Error
@fab-10 fab-10 had a problem deploying to docker-build-and-e2e June 20, 2025 15:51 — with GitHub Actions Error
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the feat/sequencer-use-distribution-artifact branch from 2875625 to 0e64154 Compare July 8, 2025 17:41
@fab-10 fab-10 had a problem deploying to docker-build-and-e2e July 8, 2025 17:41 — with GitHub Actions Error
@fab-10 fab-10 had a problem deploying to docker-build-and-e2e July 9, 2025 15:21 — with GitHub Actions Error
@fab-10 fab-10 force-pushed the feat/sequencer-use-distribution-artifact branch from 78dfb05 to 858cd71 Compare July 9, 2025 15:57
@fab-10 fab-10 had a problem deploying to docker-build-and-e2e July 9, 2025 15:57 — with GitHub Actions Error
@fab-10 fab-10 marked this pull request as ready for review July 9, 2025 16:00
cursor[bot]

This comment was marked as outdated.

@fab-10 fab-10 force-pushed the feat/sequencer-use-distribution-artifact branch from 858cd71 to 3844fcf Compare July 9, 2025 16:07
@fab-10 fab-10 temporarily deployed to docker-build-and-e2e July 9, 2025 16:07 — with GitHub Actions Inactive
cursor[bot]

This comment was marked as outdated.

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the feat/sequencer-use-distribution-artifact branch from 3844fcf to de6edc1 Compare July 9, 2025 16:22
@fab-10 fab-10 temporarily deployed to docker-build-and-e2e July 9, 2025 16:23 — with GitHub Actions Inactive
cursor[bot]

This comment was marked as outdated.

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 temporarily deployed to docker-build-and-e2e July 9, 2025 16:46 — with GitHub Actions Inactive
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect Path Breaks Build Fallback

The localBesuDir relative path in dist.gradle was incorrectly changed from ../../besu to ../../../../besu. This doubles the directory depth, causing the fallback mechanism to fail when attempting to locate a local Besu installation, thus breaking the build process if the Besu distribution download fails.

besu-plugins/linea-sequencer/gradle/dist.gradle#L37-L38

? file("${findProperty('useLocalBesuDir')}".replaceFirst('^~', System.getProperty('user.home')))
: new File(projectDir, "../../../../besu")

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Contributor

@jonesho jonesho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just few minor comments

@fab-10 fab-10 merged commit 661a040 into main Jul 10, 2025
39 checks passed
@fab-10 fab-10 deleted the feat/sequencer-use-distribution-artifact branch July 10, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants