-
Notifications
You must be signed in to change notification settings - Fork 91
Feat: Update Linea Besu package to latest Besu and plugin versions #1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5b6690d
to
6e59d28
Compare
6e59d28
to
4dcb0ae
Compare
4dcb0ae
to
3218347
Compare
3218347
to
fb3c521
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
=========================================
Coverage 65.58% 65.58%
Complexity 1402 1402
=========================================
Files 361 361
Lines 14039 14039
Branches 1345 1345
=========================================
Hits 9208 9208
Misses 4249 4249
Partials 582 582
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
fb3c521
to
5bf9493
Compare
5bf9493
to
3aa30a9
Compare
3aa30a9
to
d1937fc
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
2875625
to
0e64154
Compare
78dfb05
to
858cd71
Compare
858cd71
to
3844fcf
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
3844fcf
to
de6edc1
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Incorrect Path Breaks Build Fallback
The localBesuDir
relative path in dist.gradle
was incorrectly changed from ../../besu
to ../../../../besu
. This doubles the directory depth, causing the fallback mechanism to fail when attempting to locate a local Besu installation, thus breaking the build process if the Besu distribution download fails.
besu-plugins/linea-sequencer/gradle/dist.gradle#L37-L38
linea-monorepo/besu-plugins/linea-sequencer/gradle/dist.gradle
Lines 37 to 38 in fdf22ce
? file("${findProperty('useLocalBesuDir')}".replaceFirst('^~', System.getProperty('user.home'))) | |
: new File(projectDir, "../../../../besu") |
Was this report helpful? Give feedback by reacting with 👍 or 👎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just few minor comments
Related to #1115
Updated Besu and plugins to latest version, with support for the limitless prover.
Disable parallel tx processing in Besu until it is fully supported by Linea, since it is creating concurrency issues when used with the Shomei plugin and the Tracer.
Removed also the publication of the jar, since only the zip is needed now.
NOTE: if you wonder why in some places
Xbonsai-parallel-tx-processing-enabled=false
is used, while in otherbonsai-parallel-tx-processing-enabled=false
is used, it is because the former is compatible also with the previous version of Besu so it must be used for tests that will be updated only when the new Linea Besu Package is released after this PR is merged, at that point we can aligned the options to only used the new version.Checklist