Skip to content

chore: added test fixtures dependencies in kotlin-common-conventions #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025

Conversation

jonesho
Copy link
Contributor

@jonesho jonesho commented Jun 18, 2025

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jonesho jonesho self-assigned this Jun 18, 2025
@jonesho jonesho requested a review from a team June 18, 2025 07:09
@jonesho jonesho temporarily deployed to docker-build-and-e2e June 18, 2025 07:09 — with GitHub Actions Inactive
@jonesho jonesho requested a review from kyzooghost June 18, 2025 07:09
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.72%. Comparing base (e66abc6) to head (9acd89b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1178      +/-   ##
============================================
- Coverage     65.78%   65.72%   -0.06%     
+ Complexity     1375     1373       -2     
============================================
  Files           359      359              
  Lines         13735    13735              
  Branches       1297     1297              
============================================
- Hits           9035     9028       -7     
- Misses         4141     4146       +5     
- Partials        559      561       +2     
Flag Coverage Δ *Carryforward flag
hardhat 99.07% <ø> (ø) Carriedforward from 3de492d
kotlin 63.19% <ø> (-0.06%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kyzooghost
kyzooghost previously approved these changes Jun 18, 2025
@jonesho jonesho merged commit 8028519 into main Jun 18, 2025
28 checks passed
@jonesho jonesho deleted the chore/test-dependencies-declaration branch June 18, 2025 08:07
thedarkjester pushed a commit that referenced this pull request Jun 18, 2025
…1178)

* chore: added test fixtures dependencies in kotlin-common-conventions

* feat: revise description message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants