Use NatSpec for ITokenBridge events and errors #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedarkjester
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
=========================================
Coverage 70.69% 70.69%
Complexity 1059 1059
=========================================
Files 291 291
Lines 11972 11972
Branches 1106 1106
=========================================
Hits 8464 8464
Misses 3031 3031
Partials 477 477
|
thedarkjester
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Failure
thedarkjester
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Failure
Julink-eth
reviewed
Oct 18, 2024
thedarkjester
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Failure
count-sum
previously approved these changes
Oct 18, 2024
VGau
reviewed
Oct 18, 2024
VGau
previously approved these changes
Oct 18, 2024
VGau
approved these changes
Oct 18, 2024
VGau
approved these changes
Oct 18, 2024
thedarkjester
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
thedarkjester
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
VGau
approved these changes
Oct 18, 2024
bradbown
approved these changes
Oct 18, 2024
thedarkjester
added a commit
that referenced
this pull request
Oct 18, 2024
* Use NatSpec for ITokenBridge events and errors * pass 1 of NatSpec cleanup * natspec pass 2 * correct wording on NatSpec * use correct indexed keyword location
thedarkjester
added a commit
that referenced
this pull request
Oct 18, 2024
* smart-contract: small tweak on validation and consistent naming on params * use currentL2BlockNumber vs. memory * cache blobFirstBlockNumber * optimize blob number validation * cache snarkhash and finalStateRootHash * remove redundant checks * remove block numbers from blob submits * remove extra space * address naming considerations * use updated ABI for V6 LineaRollup * Use NatSpec for ITokenBridge events and errors (#202) * Use NatSpec for ITokenBridge events and errors * pass 1 of NatSpec cleanup * natspec pass 2 * correct wording on NatSpec * use correct indexed keyword location --------- Signed-off-by: The Dark Jester <thedarkjester@users.noreply.github.com> Co-authored-by: Pedro Novais <1478752+jpnovais@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #
Checklist