Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added verifier check in sticker, fixed the edge case in product #204

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

Soleimani193
Copy link
Contributor

This PR adds the verifier check for the local opening in the stitcker compiler.
It also addresses the edge case 0^0=1 in the symbolic.NewProduct()

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@Soleimani193 Soleimani193 added the Prover Tag to use for all work impacting the prover label Oct 17, 2024
@Soleimani193 Soleimani193 self-assigned this Oct 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.59%. Comparing base (5fad7f7) to head (2d6be64).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #204   +/-   ##
=========================================
  Coverage     70.59%   70.59%           
  Complexity     1059     1059           
=========================================
  Files           291      291           
  Lines         11960    11960           
  Branches       1103     1051   -52     
=========================================
  Hits           8443     8443           
  Misses         3039     3039           
  Partials        478      478           
Flag Coverage Δ
hardhat 98.67% <ø> (ø)
kotlin 68.28% <ø> (ø)

@Soleimani193 Soleimani193 marked this pull request as ready for review October 17, 2024 13:43
Copy link
Contributor

@gusiri gusiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Soleimani193 Soleimani193 changed the title Prover/fix verifier check in sticker added verifier check in sticker, fixed the edge case in product Oct 17, 2024
@AlexandreBelling AlexandreBelling merged commit 62438cb into main Oct 21, 2024
5 checks passed
@AlexandreBelling AlexandreBelling deleted the prover/fix-verifier-check-in-sticker branch October 21, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prover Tag to use for all work impacting the prover
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants