Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] G-01 Removing old initialize function #212

Merged
merged 4 commits into from
Oct 31, 2024
Merged

[Fix] G-01 Removing old initialize function #212

merged 4 commits into from
Oct 31, 2024

Conversation

thedarkjester
Copy link
Collaborator

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@thedarkjester thedarkjester requested a review from a team as a code owner October 21, 2024 11:15
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.67%. Comparing base (5dc02f8) to head (eeef54d).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #212      +/-   ##
============================================
- Coverage     71.04%   70.67%   -0.38%     
+ Complexity     1082     1043      -39     
============================================
  Files           301      290      -11     
  Lines         12319    11757     -562     
  Branches       1154     1095      -59     
============================================
- Hits           8752     8309     -443     
+ Misses         3075     2974     -101     
+ Partials        492      474      -18     
Flag Coverage Δ *Carryforward flag
hardhat 98.67% <ø> (-0.01%) ⬇️
kotlin 68.33% <ø> (-0.52%) ⬇️ Carriedforward from 62513af

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...s/contracts/messageService/l2/L2MessageManager.sol 100.00% <ø> (ø)
...tracts/messageService/l2/v1/L2MessageManagerV1.sol 100.00% <ø> (ø)

... and 201 files with indirect coverage changes

@devdacian
Copy link

Fix looks good to me.

@VGau VGau merged commit 9a588d8 into main Oct 31, 2024
7 of 8 checks passed
@VGau VGau deleted the fix/g-01 branch October 31, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants